mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-04 22:20:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

[3.6] bpo-31471: Fix assertion failure in subprocess.Popen() on Windows, in case env has a bad keys() method. (GH-3580) (#3584)

Browse source 
(cherry picked from commit 0b3a87ef54)
This commit is contained in:
Miss Islington (bot) 2017-09-14 12:56:31 -07:00 • committed by Serhiy Storchaka
parent 20fa05d022
commit f135f62cfd
3 changed files with 16 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Modules/_winapi.c
View file

@ -723,9 +723,13 @@ getenvironment(PyObject* environment)
}
keys = PyMapping_Keys(environment);
if (!keys) {
return NULL;
}
values = PyMapping_Values(environment);
if (!keys || !values)
if (!values) {
goto error;
}
envsize = PySequence_Fast_GET_SIZE(keys);
if (PySequence_Fast_GET_SIZE(values) != envsize) {