mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-04 00:48:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Issue #18849: Fixed a Windows-specific tempfile bug where collision with an

Browse source 
existing directory caused mkstemp and related APIs to fail instead of
retrying. Report and fix by Vlad Shcherbina.
This commit is contained in:
Eli Bendersky 2013-09-06 06:11:19 -07:00
parent 43c6ef1899
commit f315df31bd
4 changed files with 38 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Lib/test/test_tempfile.py
View file

@ -372,6 +372,32 @@ class TestMkstempInner(BaseTestCase):
os.lseek(f.fd, 0, os.SEEK_SET)
self.assertEqual(os.read(f.fd, 20), b"blat")
def test_collision_with_existing_directory(self):
# _mkstemp_inner tries another name when a directory with
# the chosen name already exists
container_dir = tempfile.mkdtemp()
try:
def mock_get_candidate_names():
return iter(['aaa', 'aaa', 'bbb'])
with support.swap_attr(tempfile,
'_get_candidate_names',
mock_get_candidate_names):
dir = tempfile.mkdtemp(dir=container_dir)
self.assertTrue(dir.endswith('aaa'))
flags = tempfile._bin_openflags
(fd, name) = tempfile._mkstemp_inner(container_dir,
tempfile.template,
'',
flags)
try:
self.assertTrue(name.endswith('bbb'))
finally:
os.close(fd)
os.unlink(name)
finally:
support.rmtree(container_dir)
class TestGetTempPrefix(BaseTestCase):
"""Test gettempprefix()."""