mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-20 02:50:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

Merge #14399: zipfile now correctly handles comments added to empty zipfiles.

Browse source 
Patch by Serhiy Storchaka.

This also moves the TypeError that results from trying to use a unicode
comment from the 'close' step to the point at which the comment is added to
the zipfile.
This commit is contained in:
R David Murray 2012-04-12 18:44:58 -04:00
parent 6125e232e2
commit f50b38a11f
3 changed files with 49 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Misc/NEWS
View file

@ -19,6 +19,11 @@ Core and Builtins
Library
-------
- Issue #14399: zipfile now correctly adds a comment even when the zipfile
being created is otherwise empty. In addition, the TypeError that results
from trying to set a non-binary value as a comment is now now raised at the
time the comment is set rather than at the time the zipfile is written.
- trace.CoverageResults.is_ignored_filename() now ignores any name that starts
with "<" and ends with ">" instead of special-casing "<string>" and
"<doctest ".