mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-10-17 04:08:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Get rid of the close_fds DeprecationWarning. Changes the default on a per

Browse source 
platform basis.  It remains False on Windows and changes to True on all
other platforms (POSIX).  Based on python-dev discussion and
http://bugs.python.org/issue7213.
This commit is contained in:
Gregory P. Smith 2010-12-13 06:45:02 +00:00
parent 8d28a92eda
commit f560485388
3 changed files with 26 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Lib/test/test_subprocess.py
View file

@ -58,22 +58,6 @@ class BaseTestCase(unittest.TestCase):
self.assertEqual(actual, expected, msg)
class DeprecationWarningTests(BaseTestCase):
def testCloseFdsWarning(self):
quick_process = [sys.executable, "-c", "import sys; sys.exit(0)"]
with warnings.catch_warnings(record=True) as warnlist:
warnings.simplefilter("always")
subprocess.call(quick_process, close_fds=True)
self.assertEqual([], warnlist)
subprocess.call(quick_process, close_fds=False)
self.assertEqual([], warnlist)
with self.assertWarns(DeprecationWarning) as wm:
subprocess.Popen(quick_process).wait()
self.assertEqual(1, len(wm.warnings))
self.assertIn('close_fds parameter was not specified',
str(wm.warnings[0]))
class ProcessTestCase(BaseTestCase):
def test_call_seq(self):
@ -1250,8 +1234,7 @@ def test_main():
ProcessTestCaseNoPoll,
HelperFunctionTests,
CommandsWithSpaces,
ContextManagerTests,
DeprecationWarningTests)
ContextManagerTests)
support.run_unittest(*unit_tests)
support.reap_children()