mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-09-27 10:50:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 13

open retrieved file in binary mode, since it's now compressed

Browse source
This commit is contained in:
Benjamin Peterson 2014-02-19 22:56:35 -05:00
parent fbf648ebba
commit f6218a2191
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Lib/test/test_urllibnet.py
View file

@ -106,7 +106,7 @@ class urlopenNetworkTests(unittest.TestCase):
# Make sure fd returned by fileno is valid. # Make sure fd returned by fileno is valid.
with self.urlopen("http://www.python.org/", timeout=None) as open_url: with self.urlopen("http://www.python.org/", timeout=None) as open_url:
fd = open_url.fileno() fd = open_url.fileno()
with os.fdopen(fd, encoding='utf-8') as f: with os.fdopen(fd, 'rb') as f:
self.assertTrue(f.read(), "reading from file created using fd " self.assertTrue(f.read(), "reading from file created using fd "
"returned by fileno failed") "returned by fileno failed")
@ -151,7 +151,7 @@ class urlretrieveNetworkTests(unittest.TestCase):
with self.urlretrieve("http://www.python.org/") as (file_location, info): with self.urlretrieve("http://www.python.org/") as (file_location, info):
self.assertTrue(os.path.exists(file_location), "file location returned by" self.assertTrue(os.path.exists(file_location), "file location returned by"
" urlretrieve is not a valid path") " urlretrieve is not a valid path")
with open(file_location, encoding='utf-8') as f: with open(file_location, 'rb') as f:
self.assertTrue(f.read(), "reading from the file location returned" self.assertTrue(f.read(), "reading from the file location returned"
" by urlretrieve failed") " by urlretrieve failed")
@ -161,7 +161,7 @@ class urlretrieveNetworkTests(unittest.TestCase):
support.TESTFN) as (file_location, info): support.TESTFN) as (file_location, info):
self.assertEqual(file_location, support.TESTFN) self.assertEqual(file_location, support.TESTFN)
self.assertTrue(os.path.exists(file_location)) self.assertTrue(os.path.exists(file_location))
with open(file_location, encoding='utf-8') as f: with open(file_location, 'rb') as f:
self.assertTrue(f.read(), "reading from temporary file failed") self.assertTrue(f.read(), "reading from temporary file failed")
def test_header(self): def test_header(self):