mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-07-23 19:25:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 11

bpo-31418: Fix an assertion failure in PyErr_WriteUnraisable() in case of an exception with a bad __module__ attribute. (#3539)

Browse source
This commit is contained in:
Oren Milman 2017-09-14 01:30:05 +03:00 • committed by Serhiy Storchaka
parent ace1ecc00b
commit f6e61df015
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Misc/NEWS.d/next/Core and Builtins/2017-09-13-13-03-52.bpo-31418.rS-FlC.rst Normal file
View file

@ -0,0 +1,2 @@
Fix an assertion failure in `PyErr_WriteUnraisable()` in case of an
exception with a bad ``__module__`` attribute. Patch by Oren Milman.

2
Python/errors.c
View file

@ -961,7 +961,7 @@ PyErr_WriteUnraisable(PyObject *obj)
} }
moduleName = _PyObject_GetAttrId(t, &PyId___module__); moduleName = _PyObject_GetAttrId(t, &PyId___module__);
if (moduleName == NULL) { if (moduleName == NULL || !PyUnicode_Check(moduleName)) {
PyErr_Clear(); PyErr_Clear();
if (PyFile_WriteString("<unknown>", f) < 0) if (PyFile_WriteString("<unknown>", f) < 0)
goto done; goto done;