mirror of
https://github.com/python/cpython.git
synced 2025-12-04 00:30:19 +00:00
Make _strptime.TimeRE().pattern() use `\s+` for matching whitespace instead
of ``\s*``. This prevents patterns from "stealing" bits from other patterns in order to make a match work. Closes bug #1730389. Will be backported.
This commit is contained in:
parent
994ebed50c
commit
f7188cefb3
3 changed files with 13 additions and 1 deletions
|
|
@ -250,7 +250,7 @@ class TimeRE(dict):
|
|||
regex_chars = re_compile(r"([\\.^$*+?\(\){}\[\]|])")
|
||||
format = regex_chars.sub(r"\\\1", format)
|
||||
whitespace_replacement = re_compile('\s+')
|
||||
format = whitespace_replacement.sub('\s*', format)
|
||||
format = whitespace_replacement.sub('\s+', format)
|
||||
while '%' in format:
|
||||
directive_index = format.index('%')+1
|
||||
processed_format = "%s%s%s" % (processed_format,
|
||||
|
|
|
|||
|
|
@ -190,6 +190,15 @@ class TimeRETests(unittest.TestCase):
|
|||
"locale data that contains regex metacharacters is not"
|
||||
" properly escaped")
|
||||
|
||||
def test_whitespace_substitution(self):
|
||||
# When pattern contains whitespace, make sure it is taken into account
|
||||
# so as to not allow to subpatterns to end up next to each other and
|
||||
# "steal" characters from each other.
|
||||
pattern = self.time_re.pattern('%j %H')
|
||||
self.failUnless(not re.match(pattern, "180"))
|
||||
self.failUnless(re.match(pattern, "18 0"))
|
||||
|
||||
|
||||
class StrptimeTests(unittest.TestCase):
|
||||
"""Tests for _strptime.strptime."""
|
||||
|
||||
|
|
|
|||
|
|
@ -222,6 +222,9 @@ Core and builtins
|
|||
Library
|
||||
-------
|
||||
|
||||
- Bug #1730389: Change time.strptime() to use ``\s+`` instead of ``\s*`` when
|
||||
matching spaces in the specified format argument.
|
||||
|
||||
- SF 1668596/1720897: distutils now copies data files
|
||||
even if package_dir is empty.
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue