mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-11-02 03:01:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

bpo-44304: Fix crash in the sqlite3 module when the GC clears Statement objects (GH-26545)

Browse source
This commit is contained in:
Pablo Galindo 2021-06-05 03:50:39 +01:00 • committed by GitHub
parent f171877ebe
commit fa106a685c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 23 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Modules/_sqlite/statement.c
View file

@ -403,6 +403,10 @@ stmt_dealloc(pysqlite_Statement *self)
if (self->in_weakreflist != NULL) {
PyObject_ClearWeakRefs((PyObject*)self);
}
if (self->st) {
sqlite3_finalize(self->st);
self->st = 0;
}
tp->tp_clear((PyObject *)self);
tp->tp_free(self);
Py_DECREF(tp);
@ -411,13 +415,6 @@ stmt_dealloc(pysqlite_Statement *self)
static int
stmt_clear(pysqlite_Statement *self)
{
if (self->st) {
Py_BEGIN_ALLOW_THREADS
sqlite3_finalize(self->st);
Py_END_ALLOW_THREADS
self->st = 0;
}
Py_CLEAR(self->sql);
return 0;
}