mirrors/cpython
1
0
Fork 0
mirror of https://github.com/python/cpython.git synced 2025-08-31 22:18:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

pathlib tests: create walk() test hierarchy without using class under test (#128338)

Browse source 
In the tests for `pathlib.Path.walk()`, avoid using the path class under
test (`self.cls`) in test setup. Instead we use `os` functions in
`test_pathlib`, and direct manipulation of `DummyPath` internal data in
`test_pathlib_abc`.
This commit is contained in:
Barney Gale 2025-01-04 15:45:24 +00:00 • committed by GitHub
parent a0088b40bb
commit fd94c6a803
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 58 additions and 39 deletions
Download patch file Download diff file Expand all files Collapse all files

38
Lib/test/test_pathlib/test_pathlib.py
View file

@ -3029,6 +3029,42 @@ class PathWalkTest(test_pathlib_abc.DummyPathWalkTest):
if name in _tests_needing_symlinks and not self.can_symlink:
self.skipTest('requires symlinks')
super().setUp()
def createTestHierarchy(self):
# Build:
# TESTFN/
# TEST1/ a file kid and two directory kids
# tmp1
# SUB1/ a file kid and a directory kid
# tmp2
# SUB11/ no kids
# SUB2/ a file kid and a dirsymlink kid
# tmp3
# link/ a symlink to TEST2
# broken_link
# broken_link2
# TEST2/
# tmp4 a lone file
t2_path = self.cls(self.base, "TEST2")
os.makedirs(self.sub11_path)
os.makedirs(self.sub2_path)
os.makedirs(t2_path)
tmp1_path = self.walk_path / "tmp1"
tmp2_path = self.sub1_path / "tmp2"
tmp3_path = self.sub2_path / "tmp3"
tmp4_path = self.cls(self.base, "TEST2", "tmp4")
for path in tmp1_path, tmp2_path, tmp3_path, tmp4_path:
with open(path, "w", encoding='utf-8') as f:
f.write(f"I'm {path} and proud of it. Blame test_pathlib.\n")
if self.can_symlink:
broken_link_path = self.sub2_path / "broken_link"
broken_link2_path = self.sub2_path / "broken_link2"
os.symlink(t2_path, self.link_path, target_is_directory=True)
os.symlink('broken', broken_link_path)
os.symlink(os.path.join('tmp3', 'broken'), broken_link2_path)
self.sub2_tree = (self.sub2_path, [], ["broken_link", "broken_link2", "link", "tmp3"])
sub21_path= self.sub2_path / "SUB21"
tmp5_path = sub21_path / "tmp3"
broken_link3_path = self.sub2_path / "broken_link3"
@ -3052,7 +3088,7 @@ class PathWalkTest(test_pathlib_abc.DummyPathWalkTest):
def tearDown(self):
if 'SUB21' in self.sub2_tree[1]:
os.chmod(self.sub2_path / "SUB21", stat.S_IRWXU)
super().tearDown()
os_helper.rmtree(self.base)
def test_walk_bad_dir(self):
errors = []