Commit graph

484 commits

Author SHA1 Message Date
Victor Stinner
f6fa22efe0 Issue #18571: Merge duplicate test code
Merge test/subprocessdata/inherited.py into test/subprocessdata/fd_status.py
2013-09-01 10:22:41 +02:00
Antoine Pitrou
267964c837 Forward port new tests from Issue #18851. 2013-08-31 00:12:37 +02:00
Antoine Pitrou
a8392717f1 Forward port new tests from Issue #18851. 2013-08-30 23:38:13 +02:00
Gregory P. Smith
6cc50391a6 Fixes Issue #15507: test_subprocess's test_send_signal could fail if the test
runner were run in an environment where the process inherited an ignore
setting for SIGINT.  Restore the SIGINT handler to the desired
KeyboardInterrupt raising one during that test.
2013-08-29 13:39:44 -07:00
Gregory P. Smith
dee0434e2f Fixes issue #15507: test_subprocess's test_send_signal could fail if the test
runner were run in an environment where the process inherited an ignore
setting for SIGINT.  Restore the SIGINT handler to the desired
KeyboardInterrupt raising one during that test.
2013-08-29 13:35:27 -07:00
Victor Stinner
daf455554b Issue #18571: Implementation of the PEP 446: file descriptors and file handles
are now created non-inheritable; add functions os.get/set_inheritable(),
os.get/set_handle_inheritable() and socket.socket.get/set_inheritable().
2013-08-28 00:53:59 +02:00
Charles-François Natali
a439b32cf0 Merge. 2013-08-25 18:28:44 +02:00
Charles-François Natali
249cdc39fc Issue #18763: subprocess: The file descriptors are now closed after calling the
preexec_fn callback, which may open file descriptors.
2013-08-25 18:24:45 +02:00
Ned Deily
582583bc41 Issue #17046: merge from 3.3 2013-08-02 18:05:31 -07:00
Ned Deily
e92dfbfec8 Issue #17046: Fix test_subprocess test_executable_without_cwd broken test case. 2013-08-02 18:02:21 -07:00
Antoine Pitrou
284e5ce67e Fix the RLIMIT_CORE resource lowering logic in test_subprocess.
We must only lower the soft limit, since lowering the hard limit makes it impossible to raise it back at the end.
(this could prevent core dumps from being generated when the test suite crashes)
2013-08-02 00:08:51 +02:00
Richard Oudkerk
a35a128acc Merge. 2013-06-10 16:31:39 +01:00
Richard Oudkerk
0e547b66dc Issue #18174: Fix fd leaks in tests. 2013-06-10 16:29:19 +01:00
Antoine Pitrou
dc49b2b88c Try to make test more reliable (saw some sporadic failures on buildbots) 2013-05-19 15:55:40 +02:00
Antoine Pitrou
5b6616dee3 Try to make test more reliable (saw some sporadic failures on buildbots) 2013-05-19 15:55:59 +02:00
Serhiy Storchaka
fcd9f22238 Issue #16624: subprocess.check_output now accepts an input argument,
allowing the subprocess's stdin to be provided as a (byte) string.
Patch by Zack Weinberg.
2013-04-22 20:20:54 +03:00
Gregory P. Smith
4a8ea9e2a6 Fixes issue #17488: Change the subprocess.Popen bufsize parameter default value
from unbuffered (0) to buffering (-1) to match the behavior existing code
expects and match the behavior of the subprocess module in Python 2 to avoid
introducing hard to track down bugs.
2013-03-23 12:00:00 -07:00
Gregory P. Smith
a1b9ed32ee Fixes issue #17488: Change the subprocess.Popen bufsize parameter default value
from unbuffered (0) to buffering (-1) to match the behavior existing code
expects and match the behavior of the subprocess module in Python 2 to avoid
introducing hard to track down bugs.
2013-03-23 11:54:22 -07:00
Gregory P. Smith
a1ed539268 Fixes issue #17488: Change the subprocess.Popen bufsize parameter default value
from unbuffered (0) to buffering (-1) to match the behavior existing code
expects and match the behavior of the subprocess module in Python 2 to avoid
introducing hard to track down bugs.
2013-03-23 11:44:25 -07:00
Ezio Melotti
c0417357d1 #11963: merge with 3.3. 2013-03-11 06:03:05 +02:00
Ezio Melotti
3300878d8c #11963: merge with 3.2. 2013-03-11 05:59:55 +02:00
Ezio Melotti
42a541bd49 #11963: remove human verification from test_parser and test_subprocess. 2013-03-11 05:53:34 +02:00
Serhiy Storchaka
b3f194d109 Issue #16903: Popen.communicate() on Unix now accepts strings when
universal_newlines is true as on Windows.
2013-02-04 16:47:39 +02:00
Charles-François Natali
6c566b3ce9 Issue #16762: Fix some test_subprocess failures on NetBSD and OpenBSD: kill()
returns ESRCH for a zombie process, which is not POSIX-compliant.
2013-01-12 16:55:31 +01:00
Charles-François Natali
dbc744ac74 Issue #16762: Fix some test_subprocess failures on NetBSD and OpenBSD: kill()
returns ESRCH for a zombie process, which is not POSIX-compliant.
2013-01-12 16:54:45 +01:00
Charles-François Natali
53221e371d Issue #16762: Fix some test_subprocess failures on NetBSD and OpenBSD: kill()
returns ESRCH for a zombie process, which is not POSIX-compliant.
2013-01-12 16:52:20 +01:00
Andrew Svetlov
0c8ee7fc8b fix test for subprocess (#16644) 2012-12-26 23:36:17 +02:00
Andrew Svetlov
b172697cd8 fix test for subprocess (#16644) 2012-12-26 23:34:54 +02:00
Andrew Svetlov
57a1233110 fix test for subprocess (#16644) 2012-12-26 23:31:45 +02:00
Andrew Svetlov
3438fa496d Get rig of EnvironmentError (#16705) 2012-12-17 23:35:18 +02:00
Gregory P. Smith
65ee6ece2d Refactor test_preexec_errpipe to not create an uncollectable reference cycle. 2012-11-11 10:12:40 -08:00
Gregory P. Smith
859035d2ef Refactor test_preexec_errpipe to not create an uncollectable reference cycle. 2012-11-11 10:00:49 -08:00
Gregory P. Smith
e27faac45f Refactor test_preexec_errpipe to not create an uncollectable reference cycle. 2012-11-11 09:59:27 -08:00
Gregory P. Smith
c2c4cb624b Fixes issue #16140: The subprocess module no longer double closes its
child subprocess.PIPE parent file descriptors on child error prior to
exec().

This would lead to race conditions in multithreaded programs where
another thread opened a file reusing the fd which was then closed out
from beneath it by the errant second close.
2012-11-11 01:41:49 -08:00
Gregory P. Smith
c8ac03d936 Fixes issue #16140: The subprocess module no longer double closes its
child subprocess.PIPE parent file descriptors on child error prior to
exec().

This would lead to race conditions in multithreaded programs where
another thread opened a file reusing the fd which was then closed out
from beneath it by the errant second close.
2012-11-11 01:38:18 -08:00
Gregory P. Smith
12489d98e6 Fixes issue #16140: The subprocess module no longer double closes its
child subprocess.PIPE parent file descriptors on child error prior to
exec().

This would lead to race conditions in multithreaded programs where
another thread opened a file reusing the fd which was then closed out
from beneath it by the errant second close.
2012-11-11 01:37:02 -08:00
Gregory P. Smith
8d07c264e4 Raise our own SubprocessError rather than a RuntimeError in when dealing with
odd rare errors coming from the subprocess module.
2012-11-10 23:53:47 -08:00
Gregory P. Smith
561cbc4e7b Fixes issue #16327: The subprocess module no longer leaks file descriptors
used for stdin/stdout/stderr pipes to the child when fork() fails.
2012-11-10 22:33:23 -08:00
Gregory P. Smith
3d8e776cd9 Fixes issue #16327: The subprocess module no longer leaks file descriptors
used for stdin/stdout/stderr pipes to the child when fork() fails.
2012-11-10 22:32:22 -08:00
Gregory P. Smith
a10ddb8a55 Fixes Issue #16114: The subprocess module no longer provides a
misleading error message stating that args[0] did not exist when
either the cwd or executable keyword arguments specified a path that
did not exist.
2012-10-10 03:44:47 -07:00
Gregory P. Smith
5591b02a4c Fixes Issue #16114: The subprocess module no longer provides a
misleading error message stating that args[0] did not exist when
either the cwd or executable keyword arguments specified a path that
did not exist.

It now keeps track of if the child got as far as preexec and reports it if
not back to the parent via a special "noexec" error message value in
the error pipe so that the cwd can be blamed for a failed chdir
instead of the exec of the executable being blamed instead.

The executable is also always reported accurately when exec fails.

Unittests enhanced to cover these cases.
2012-10-10 03:34:47 -07:00
Chris Jerdonek
86b0fb23e5 Issue #16170: Remove Linux skip from test_subprocess's test_executable test. 2012-10-09 13:17:49 -07:00
Chris Jerdonek
2d051b8eaf Issue #16115: Skip a newly added subprocess.Popen() test on Linux. 2012-10-08 17:53:46 -07:00
Chris Jerdonek
776cb199bc Issue #16115: Improve testing of the executable argument to subprocess.Popen(). 2012-10-08 15:56:43 -07:00
Andrew Svetlov
a2028733ef revert accidental inclusion of subprocess tests 2012-10-06 18:45:47 +03:00
Andrew Svetlov
b2209ccfa0 revert accidental inclusion of subprocess tests 2012-10-06 18:45:24 +03:00
Andrew Svetlov
5061a34283 Issue #16025: Minor corrections to the zipfile documentation.
Patch by Serhiy Storchaka.
2012-10-06 18:10:01 +03:00
Andrew Svetlov
afbf90c993 Issue #16025: Minor corrections to the zipfile documentation.
Patch by Serhiy Storchaka.
2012-10-06 18:02:05 +03:00
Andrew Svetlov
1a53c0cbf5 Issue #16115: Add test for check that executable arg to Popen() takes precedence over args[0] arg\n \n Patch by Kushal Das 2012-10-05 22:52:15 +03:00
Chris Jerdonek
9a6ada8026 Issue #15533: Merge update from 3.2. 2012-09-30 09:46:04 -07:00