Commit graph

245 commits

Author SHA1 Message Date
Gregory P. Smith
a10ddb8a55 Fixes Issue #16114: The subprocess module no longer provides a
misleading error message stating that args[0] did not exist when
either the cwd or executable keyword arguments specified a path that
did not exist.
2012-10-10 03:44:47 -07:00
Gregory P. Smith
5591b02a4c Fixes Issue #16114: The subprocess module no longer provides a
misleading error message stating that args[0] did not exist when
either the cwd or executable keyword arguments specified a path that
did not exist.

It now keeps track of if the child got as far as preexec and reports it if
not back to the parent via a special "noexec" error message value in
the error pipe so that the cwd can be blamed for a failed chdir
instead of the exec of the executable being blamed instead.

The executable is also always reported accurately when exec fails.

Unittests enhanced to cover these cases.
2012-10-10 03:34:47 -07:00
Chris Jerdonek
86b0fb23e5 Issue #16170: Remove Linux skip from test_subprocess's test_executable test. 2012-10-09 13:17:49 -07:00
Chris Jerdonek
2d051b8eaf Issue #16115: Skip a newly added subprocess.Popen() test on Linux. 2012-10-08 17:53:46 -07:00
Chris Jerdonek
776cb199bc Issue #16115: Improve testing of the executable argument to subprocess.Popen(). 2012-10-08 15:56:43 -07:00
Andrew Svetlov
a2028733ef revert accidental inclusion of subprocess tests 2012-10-06 18:45:47 +03:00
Andrew Svetlov
b2209ccfa0 revert accidental inclusion of subprocess tests 2012-10-06 18:45:24 +03:00
Andrew Svetlov
5061a34283 Issue #16025: Minor corrections to the zipfile documentation.
Patch by Serhiy Storchaka.
2012-10-06 18:10:01 +03:00
Andrew Svetlov
afbf90c993 Issue #16025: Minor corrections to the zipfile documentation.
Patch by Serhiy Storchaka.
2012-10-06 18:02:05 +03:00
Andrew Svetlov
1a53c0cbf5 Issue #16115: Add test for check that executable arg to Popen() takes precedence over args[0] arg\n \n Patch by Kushal Das 2012-10-05 22:52:15 +03:00
Chris Jerdonek
9a6ada8026 Issue #15533: Merge update from 3.2. 2012-09-30 09:46:04 -07:00
Chris Jerdonek
c2cd626497 Issue #15533: Skip test_cwd_with_relative_*() tests on Windows pending resolution of issue. 2012-09-30 09:45:00 -07:00
Chris Jerdonek
28714c8c26 Issue #15533: Merge fix from 3.2. 2012-09-30 02:15:37 -07:00
Chris Jerdonek
ec3ea94251 Issue #15533: Clarify docs and add tests for subprocess.Popen()'s cwd argument. 2012-09-30 00:10:28 -07:00
Andrew Svetlov
a19de803e4 Issue #15595: Fix subprocess.Popen(universal_newlines=True)
for certain locales (utf-16 and utf-32 family).

Patch by Chris Jerdonek.
2012-08-19 22:20:03 +03:00
Andrew Svetlov
828607170d Issue #15595: Fix subprocess.Popen(universal_newlines=True)
for certain locales (utf-16 and utf-32 family).

Patch by Chris Jerdonek.
2012-08-19 22:13:41 +03:00
Andrew Svetlov
47ec25d2f6 Brush subprocess tests a bit. 2012-08-19 16:25:37 +03:00
Andrew Svetlov
943c5b31b6 Fix subprocess test broken on Windows 2012-08-16 20:17:47 +03:00
Andrew Svetlov
5395d2f07d Add yet another test for subprocess.Popen.communicate 2012-08-15 22:46:43 +03:00
Andrew Svetlov
aa0dbdc2dd Issue #15592. Fix regression: subprocess.communicate() breaks on no input with universal newlines true.
Patch by Chris Jerdonek.
2012-08-14 18:40:21 +03:00
Andrew Svetlov
f3765071eb Add test to explicit check the absence regression in subprocess (issue #15592).
Patch by Chris Jerdonek.
2012-08-14 18:35:17 +03:00
Antoine Pitrou
6f1a40ffd3 Merge universal newlines-related fixes (issue #13119) 2012-08-05 00:25:31 +02:00
Antoine Pitrou
ec2d26930c Fix universal newlines test to avoid the newline translation done by sys.stdout. 2012-08-05 00:23:40 +02:00
Vinay Sajip
7ded1f0f69 Implemented PEP 405 (Python virtual environments). 2012-05-26 03:45:29 +01:00
Antoine Pitrou
b69ef16fe6 Issue #14252: Fix subprocess.Popen.terminate() to not raise an error under Windows when the child process has already exited. 2012-03-11 19:33:29 +01:00
Antoine Pitrou
1f9a835400 Issue #14252: Fix subprocess.Popen.terminate() to not raise an error under Windows when the child process has already exited. 2012-03-11 19:29:12 +01:00
Ross Lagerwall
e7ad419058 Fix sporadic test_subprocess regression introduced by 834650d63130. 2012-02-22 06:02:07 +02:00
Georg Brandl
2fb477c0f0 Merge 3.2: Issue #13703 plus some related test suite fixes. 2012-02-21 00:33:36 +01:00
Georg Brandl
a86b262d1e Fix bad inheritance in test_subprocess that led to a number of tests being executed twice. 2012-02-20 21:34:57 +01:00
Ross Lagerwall
003c7a3fca Fix a typo. 2012-02-12 09:02:01 +02:00
Ross Lagerwall
ab66d2a6cb Attempt to speed up some subprocess tests (and hopefully keep them reliable). 2012-02-12 09:01:30 +02:00
Gregory P. Smith
0648458b84 Fix a unittest error seen on NetBSD 5. 2012-01-21 22:06:09 -08:00
Gregory P. Smith
886455cc4e Fix a unittest error seen on NetBSD 5. 2012-01-21 22:05:10 -08:00
Gregory P. Smith
d635af5a61 Fixes issue #8052: The posix subprocess module's close_fds behavior was
suboptimal by closing all possible file descriptors rather than just
the open ones in the child process before exec().

It now closes only the open fds when it is possible to safely determine what
those are.
2012-01-21 14:39:29 -08:00
Gregory P. Smith
8facece99a Fixes issue #8052: The posix subprocess module's close_fds behavior was
suboptimal by closing all possible file descriptors rather than just
the open ones in the child process before exec().

It now closes only the open fds when it is possible to safely determine what
those are.
2012-01-21 14:01:08 -08:00
Benjamin Peterson
ce2af33562 merge 3.2 2011-12-10 12:44:37 -05:00
Benjamin Peterson
b870aa1255 we're always going to have gc 2011-12-10 12:44:25 -05:00
Benjamin Peterson
d3a345a21f merge 3.2 2011-12-10 12:38:52 -05:00
Benjamin Peterson
964561bb7c you can't get resource.error if you can't import resource 2011-12-10 12:31:42 -05:00
Nadeem Vawda
74adbaa7bd Merge: Fix ResourceWarnings in test_subprocess. 2011-08-19 05:14:40 +02:00
Nadeem Vawda
0d7cda3e63 Fix ResourceWarnings in test_subprocess. 2011-08-19 05:12:01 +02:00
Charles-François Natali
2736c5d47c Issue #12650: fix failures on some buildbots, when a subprocess takes a long
time to spawn.
2011-08-19 00:25:07 +02:00
Charles-François Natali
72d161af51 Issue #12650: fix failures on some buildbots, when a subprocess takes a long
time to spawn.
2011-08-19 00:24:00 +02:00
Benjamin Peterson
c07f3be4e0 merge 3.2 2011-08-18 13:55:31 -05:00
Charles-François Natali
134a8baed9 Issue #12650: Fix a race condition where a subprocess.Popen could leak
resources (FD/zombie) when killed at the wrong time.
2011-08-18 18:49:39 +02:00
Ross Lagerwall
114f0e499d Issue #12607: Merge with 3.2. 2011-07-27 07:39:27 +02:00
Ross Lagerwall
d98646e430 Issue #12607: In subprocess, fix issue where if stdin, stdout or stderr is
given as a low fd, it gets overwritten.
2011-07-27 07:16:31 +02:00
Antoine Pitrou
e02891b459 Issue #12591: Improve support of "universal newlines" in the subprocess
module: the piped streams can now be properly read from or written to.
2011-07-23 22:04:41 +02:00
Antoine Pitrou
ab85ff3d1a Issue #12591: Improve support of "universal newlines" in the subprocess
module: the piped streams can now be properly read from or written to.

(this was broken due to the 2.x to 3.x transition; communicate() support
is still sketchy)
2011-07-23 22:03:45 +02:00
Victor Stinner
5351a1f956 (merge 3.2) Issue #12493: skip test_communicate_eintr() if signal.SIGALRM is missing 2011-07-05 14:50:08 +02:00