Commit graph

178 commits

Author SHA1 Message Date
R David Murray
4c7f995e80 #7159: generalize urllib prior auth support.
This fix is a superset of the functionality introduced by the issue #19494
enhancement, and supersedes that fix.  Instead of a new handler, we have a new
password manager that tracks whether we should send the auth for a given uri.
This allows us to say "always send", satisfying #19494, or track that we've
succeeded in auth and send the creds right away on every *subsequent* request.
The support for using the password manager is added to AbstractBasicAuth,
which means the proxy handler also now can handle prior auth if passed
the new password manager.

Patch by Akshit Khurana, docs mostly by me.
2015-04-16 16:36:18 -04:00
Berker Peksag
fc080fcc7c Issue #23387: Skip test_issue16464 if it raises an 5xx error.
Also, remove support.run_doctest() since there is no doctests in
test_urllib2 and urllib.request.
2015-03-02 06:01:37 +02:00
Berker Peksag
bcdfc6a1fa Issue #23387: Skip test_issue16464 if it raises an 5xx error.
Also, remove support.run_doctest() since there is no doctests in
test_urllib2 and urllib.request.
2015-03-02 06:01:01 +02:00
Serhiy Storchaka
0e992b352a Issue #7665: Fixed tests test_ntpath and test_urllib2 when ran in the
directory containing a backslash.
2015-01-26 10:26:29 +02:00
Serhiy Storchaka
5106d044ec Issue #7665: Fixed tests test_ntpath and test_urllib2 when ran in the
directory containing a backslash.
2015-01-26 10:26:14 +02:00
Nick Coghlan
c216c48699 Close #19494: add urrlib.request.HTTPBasicPriorAuthHandler
This auth handler adds the Authorization header to the first
HTTP request rather than waiting for a HTTP 401 Unauthorized
response from the server as the default HTTPBasicAuthHandler
does.

This allows working with websites like https://api.github.com which do
not follow the strict interpretation of RFC, but more the dicta in the
end of section 2 of RFC 2617:

    > A client MAY preemptively send the corresponding Authorization
    > header with requests for resources in that space without receipt
    > of another challenge from the server.  Similarly, when a client
    > sends a request to a proxy, it may reuse a userid and password in
    > the Proxy-Authorization header field without receiving another
    > challenge from the proxy server. See section 4 for security
    > considerations associated with Basic authentication.

Patch by Matej Cepl.
2014-11-12 23:33:50 +10:00
Serhiy Storchaka
f54c350160 Issue #19524: Fixed resource leak in the HTTP connection when an invalid
response is received.  Patch by Martin Panter.
2014-09-06 21:41:39 +03:00
Senthil Kumaran
bc07ac5180 Fix localhost checking in FileHandler. Raised in #21970. 2014-07-22 00:15:20 -07:00
Senthil Kumaran
d8e24f1f71 Convert urllib.request parse_proxy doctests to unittests. 2014-04-14 16:32:20 -04:00
Ned Deily
5a507f0f05 Issue #20939: Use www.example.com instead of www.python.org to avoid test
failures when ssl is not present.
2014-03-26 23:31:39 -07:00
Ned Deily
e74153a436 Issue #20939: Backout test_urllib2.test_issue16464 disables:
68335b8afb1f 3.4
    ad0c75b7bd7d default
2014-03-26 23:26:03 -07:00
Victor Stinner
9a90243f8b Skip test_urllib2.test_issue16464() is the ssl module is missing 2014-03-19 17:31:20 +01:00
R David Murray
d3b3bba2ed Merge: #20933: At least one place maps 'test' to 'localhost'...fix test. 2014-03-15 12:03:02 -04:00
R David Murray
fdbe918eb0 #20933: At least one place maps 'test' to 'localhost'...fix test.
Discovery and patch by Wenzhu Man.  University of Waterloo apparently
maps the local name 'test' to localhost, which is in the bypass list,
causing the test to fail.  So change 'test' to a name unlikely to get
mapped to localhost.
2014-03-15 12:00:14 -04:00
Serhiy Storchaka
d3e1207191 Issue #20555: Use specific asserts in urllib, httplib, ftplib, cgi, wsgiref tests. 2014-02-08 14:51:10 +02:00
Serhiy Storchaka
25d8aeac7c Issue #20555: Use specific asserts in urllib, httplib, ftplib, cgi, wsgiref tests. 2014-02-08 14:50:08 +02:00
Senthil Kumaran
b6fac245b5 Backporing the fix from Issue #12692 2013-12-28 17:36:18 -08:00
Senthil Kumaran
0b5463fef2 Fix typo 2013-09-09 23:13:06 -07:00
Jason R. Coombs
4a6524295d Issue #18978: Add tests to capture expected behavior for class-level method overrides. 2013-09-08 13:03:40 -04:00
Senthil Kumaran
8307075ce8 Fix #17272 - Make Request.full_url and Request.get_full_url return same result under all circumstances.
Document the change of Request.full_url to a property.
2013-05-24 09:14:12 -07:00
Senthil Kumaran
5238092592 Issue #17272: Making the urllib.request's Request.full_url a descriptor. Fixes
bugs with assignment to full_url. Patch by Demian Brecht.
2013-04-25 05:45:48 -07:00
Senthil Kumaran
d281c73536 #17648 - convert test_urllib2.py doctests to unittests 2013-04-09 06:00:16 -07:00
Senthil Kumaran
fa1b02a126 #17648 - Clean up test_urllib2.py. Converted doctests to unittest for
expansion.
2013-04-08 22:24:17 -07:00
R David Murray
9cc7d45571 #17485: Delete the Content-Length header if the data attribute is deleted.
This is a follow on to issue 16464.  Original patch by Daniel Wozniak.
2013-03-20 00:10:51 -04:00
Senthil Kumaran
94f2788a85 #17471: merge from 3.3 2013-03-19 16:52:06 -07:00
Senthil Kumaran
f47e77f343 #17471 - merge from 3.2 2013-03-19 16:46:34 -07:00
Senthil Kumaran
2a4d24510a #17471 - Increasing the urllib.error test coverage. Bringing it to 100%. Based on patch contributed by Daniel Wozniak 2013-03-19 16:11:07 -07:00
Senthil Kumaran
0085ce8920 #17471 - merge from 3.3 2013-03-19 13:44:42 -07:00
Senthil Kumaran
d17ca23828 #17471 - merge from 3.2 2013-03-19 13:44:17 -07:00
Senthil Kumaran
843fae9312 #17471 - Improve urllib2 test coverage. Patch contributed by Daniel Wozniak 2013-03-19 13:43:42 -07:00
Senthil Kumaran
e9853daff9 Refactor test_urllib2. Include test_HTTPError_interface under MiscTests 2013-03-19 12:07:43 -07:00
Senthil Kumaran
41518b4af0 #17474 - Remove the various deprecated methods of Request class. 2013-03-18 18:06:00 -07:00
Brett Cannon
80512de43b Skip a test unless the network resource is available. 2013-01-25 22:27:21 -05:00
Senthil Kumaran
0a6b9eca68 merge from 3.2
Fix Issue15701 - HTTPError info method call raises AttributeError. Fix that to return headers correctly
2012-12-23 09:12:13 -08:00
Senthil Kumaran
41e66a26b0 Fix Issue15701 - HTTPError info method call raises AttributeError. Fix that to return headers correctly 2012-12-23 09:04:24 -08:00
Andrew Svetlov
fd43b4d3e4 replace threw with raised (#16714) 2012-12-19 22:55:40 +02:00
Andrew Svetlov
1f415cf2c2 replace threw with raised (#16714) 2012-12-19 22:54:47 +02:00
Andrew Svetlov
7bd61cbc03 replace threw with raised (#16714) 2012-12-19 22:49:25 +02:00
Andrew Svetlov
0832af6628 Issue #16717: get rid of socket.error, replace with OSError 2012-12-18 23:10:48 +02:00
Senthil Kumaran
5962cce050 Fix Issue15701 : add .headers attribute to urllib.error.HTTPError 2012-12-10 02:09:35 -08:00
Andrew Svetlov
bff98fe536 Issue #16464: reset Request's Content-Length header on .data change.
It will be recalculated on sending request to HTTP server.

Patch by Alexey Kachayev
2012-11-27 23:06:19 +02:00
Nadeem Vawda
bd26b5463e Issue #12692: Fix resource leak in urllib.request. 2012-10-21 17:37:43 +02:00
Senthil Kumaran
77ebfccd4d Fix Issue 15743 - improve urllib tests by removing deprecated method usages. Patch by Jeff Knupp. 2012-08-20 13:43:59 -07:00
Senthil Kumaran
92a5bf0c0a Issue12541 - Add UserWarning for unquoted realms 2012-05-16 00:03:29 +08:00
Senthil Kumaran
0ea91cb5c6 Issue12541 - Add UserWarning for unquoted realms 2012-05-15 23:59:42 +08:00
Senthil Kumaran
b26fe2f313 merge from 3.2 - Issue #12541: Be lenient with quotes around Realm field of HTTP Basic Authentation in urllib2. 2012-05-15 22:39:17 +08:00
Senthil Kumaran
34f3fcc269 Issue #12541: Be lenient with quotes around Realm field of HTTP Basic Authentation in urllib2.
G: changed Misc/NEWS
2012-05-15 22:30:25 +08:00
Senthil Kumaran
80a133b91c code improvement. 'as cm' not required when not used. Review comment by Georg Brandl 2012-04-12 19:28:07 +08:00
Senthil Kumaran
08bd4aaaf9 use assertWarns instead of check_warnings - Issue14341 2012-04-11 23:05:49 +08:00
Senthil Kumaran
2f9bf35007 Fix the buildbot breakdown - issue 10050 2012-03-14 13:59:56 -07:00