mirror of
https://github.com/python/cpython.git
synced 2025-07-23 03:05:38 +00:00

svn+ssh://pythondev@svn.python.org/python/trunk ................ r67806 | benjamin.peterson | 2008-12-15 21:35:28 -0600 (Mon, 15 Dec 2008) | 111 lines Merged revisions 67427,67431,67433,67435,67630,67652,67656-67657,67674-67675,67678-67679,67705-67706,67716,67723,67765-67771,67774,67776,67778 via svnmerge from svn+ssh://pythondev@svn.python.org/sandbox/trunk/2to3/lib2to3 ........ r67427 | benjamin.peterson | 2008-11-28 16:07:41 -0600 (Fri, 28 Nov 2008) | 1 line fix spelling in comment ........ r67431 | benjamin.peterson | 2008-11-28 17:14:08 -0600 (Fri, 28 Nov 2008) | 1 line add a scripts directory; move things to it ........ r67433 | benjamin.peterson | 2008-11-28 17:18:48 -0600 (Fri, 28 Nov 2008) | 1 line run svneol.py ........ r67435 | benjamin.peterson | 2008-11-28 17:25:03 -0600 (Fri, 28 Nov 2008) | 1 line rename pre/post_order_mapping to pre/post_order_heads ........ r67630 | alexandre.vassalotti | 2008-12-06 21:51:56 -0600 (Sat, 06 Dec 2008) | 2 lines Fix typo in the urllib2.HTTPDigestAuthHandler fixer. ........ r67652 | armin.ronacher | 2008-12-07 15:39:43 -0600 (Sun, 07 Dec 2008) | 5 lines Added a fixer that cleans up a tuple argument to isinstance after the tokens in it were fixed. This is mainly used to remove double occurrences of tokens as a leftover of the long -> int / unicode -> str conversion. ........ r67656 | armin.ronacher | 2008-12-07 16:54:16 -0600 (Sun, 07 Dec 2008) | 3 lines Added missing copyright fo 2to3 fix_isinstance. ........ r67657 | armin.ronacher | 2008-12-07 18:29:35 -0600 (Sun, 07 Dec 2008) | 3 lines 2to3: intern and reduce fixes now add the imports if missing. Because that is a common task the fixer_util module now has a function "touch_import" that adds imports if missing. ........ r67674 | benjamin.peterson | 2008-12-08 19:58:11 -0600 (Mon, 08 Dec 2008) | 1 line copy permission bits when making backup files #4602 ........ r67675 | benjamin.peterson | 2008-12-08 19:59:11 -0600 (Mon, 08 Dec 2008) | 1 line add forgotten import ........ r67678 | benjamin.peterson | 2008-12-08 20:08:30 -0600 (Mon, 08 Dec 2008) | 1 line fix #4602 for real ........ r67679 | armin.ronacher | 2008-12-09 00:54:03 -0600 (Tue, 09 Dec 2008) | 3 lines Removed redudant code from the 2to3 long fixer. This fixes #4590. ........ r67705 | benjamin.peterson | 2008-12-11 13:04:08 -0600 (Thu, 11 Dec 2008) | 1 line put trailers after a range call after the list() ........ r67706 | benjamin.peterson | 2008-12-11 13:17:57 -0600 (Thu, 11 Dec 2008) | 1 line add html related modules to the fix_imports mapping ........ r67716 | benjamin.peterson | 2008-12-11 22:16:47 -0600 (Thu, 11 Dec 2008) | 1 line consolidate tests ........ r67723 | benjamin.peterson | 2008-12-12 19:49:31 -0600 (Fri, 12 Dec 2008) | 1 line fix name ........ r67765 | benjamin.peterson | 2008-12-14 14:05:05 -0600 (Sun, 14 Dec 2008) | 1 line run fix_isinstance after fix_long and fix_unicode ........ r67766 | benjamin.peterson | 2008-12-14 14:13:05 -0600 (Sun, 14 Dec 2008) | 1 line use run_order instead of order ........ r67767 | benjamin.peterson | 2008-12-14 14:28:12 -0600 (Sun, 14 Dec 2008) | 1 line don't retain parenthesis if there is only one item left ........ r67768 | benjamin.peterson | 2008-12-14 14:32:30 -0600 (Sun, 14 Dec 2008) | 1 line use insert_child() ........ r67769 | benjamin.peterson | 2008-12-14 14:59:10 -0600 (Sun, 14 Dec 2008) | 1 line parenthesize doesn't belong in pygram or FixerBase ........ r67770 | alexandre.vassalotti | 2008-12-14 15:15:36 -0600 (Sun, 14 Dec 2008) | 2 lines Fix typo: html.paser -> html.parser. ........ r67771 | benjamin.peterson | 2008-12-14 15:22:09 -0600 (Sun, 14 Dec 2008) | 1 line altering .children needs to call changed() ........ r67774 | benjamin.peterson | 2008-12-14 15:55:38 -0600 (Sun, 14 Dec 2008) | 1 line employ an evil hack to fix multiple names in the same import statement ........ r67776 | benjamin.peterson | 2008-12-14 16:22:38 -0600 (Sun, 14 Dec 2008) | 1 line make a common mixin class for Test_imports and friends ........ r67778 | alexandre.vassalotti | 2008-12-14 17:48:20 -0600 (Sun, 14 Dec 2008) | 2 lines Make fix_imports refactor multiple imports as. ........ ................
109 lines
3.1 KiB
Python
109 lines
3.1 KiB
Python
# Copyright 2006 Google, Inc. All Rights Reserved.
|
|
# Licensed to PSF under a Contributor Agreement.
|
|
|
|
"""Fixer for has_key().
|
|
|
|
Calls to .has_key() methods are expressed in terms of the 'in'
|
|
operator:
|
|
|
|
d.has_key(k) -> k in d
|
|
|
|
CAVEATS:
|
|
1) While the primary target of this fixer is dict.has_key(), the
|
|
fixer will change any has_key() method call, regardless of its
|
|
class.
|
|
|
|
2) Cases like this will not be converted:
|
|
|
|
m = d.has_key
|
|
if m(k):
|
|
...
|
|
|
|
Only *calls* to has_key() are converted. While it is possible to
|
|
convert the above to something like
|
|
|
|
m = d.__contains__
|
|
if m(k):
|
|
...
|
|
|
|
this is currently not done.
|
|
"""
|
|
|
|
# Local imports
|
|
from .. import pytree
|
|
from ..pgen2 import token
|
|
from .. import fixer_base
|
|
from ..fixer_util import Name, parenthesize
|
|
|
|
|
|
class FixHasKey(fixer_base.BaseFix):
|
|
|
|
PATTERN = """
|
|
anchor=power<
|
|
before=any+
|
|
trailer< '.' 'has_key' >
|
|
trailer<
|
|
'('
|
|
( not(arglist | argument<any '=' any>) arg=any
|
|
| arglist<(not argument<any '=' any>) arg=any ','>
|
|
)
|
|
')'
|
|
>
|
|
after=any*
|
|
>
|
|
|
|
|
negation=not_test<
|
|
'not'
|
|
anchor=power<
|
|
before=any+
|
|
trailer< '.' 'has_key' >
|
|
trailer<
|
|
'('
|
|
( not(arglist | argument<any '=' any>) arg=any
|
|
| arglist<(not argument<any '=' any>) arg=any ','>
|
|
)
|
|
')'
|
|
>
|
|
>
|
|
>
|
|
"""
|
|
|
|
def transform(self, node, results):
|
|
assert results
|
|
syms = self.syms
|
|
if (node.parent.type == syms.not_test and
|
|
self.pattern.match(node.parent)):
|
|
# Don't transform a node matching the first alternative of the
|
|
# pattern when its parent matches the second alternative
|
|
return None
|
|
negation = results.get("negation")
|
|
anchor = results["anchor"]
|
|
prefix = node.get_prefix()
|
|
before = [n.clone() for n in results["before"]]
|
|
arg = results["arg"].clone()
|
|
after = results.get("after")
|
|
if after:
|
|
after = [n.clone() for n in after]
|
|
if arg.type in (syms.comparison, syms.not_test, syms.and_test,
|
|
syms.or_test, syms.test, syms.lambdef, syms.argument):
|
|
arg = parenthesize(arg)
|
|
if len(before) == 1:
|
|
before = before[0]
|
|
else:
|
|
before = pytree.Node(syms.power, before)
|
|
before.set_prefix(" ")
|
|
n_op = Name("in", prefix=" ")
|
|
if negation:
|
|
n_not = Name("not", prefix=" ")
|
|
n_op = pytree.Node(syms.comp_op, (n_not, n_op))
|
|
new = pytree.Node(syms.comparison, (arg, n_op, before))
|
|
if after:
|
|
new = parenthesize(new)
|
|
new = pytree.Node(syms.power, (new,) + tuple(after))
|
|
if node.parent.type in (syms.comparison, syms.expr, syms.xor_expr,
|
|
syms.and_expr, syms.shift_expr,
|
|
syms.arith_expr, syms.term,
|
|
syms.factor, syms.power):
|
|
new = parenthesize(new)
|
|
new.set_prefix(prefix)
|
|
return new
|