mirror of
https://github.com/python/cpython.git
synced 2025-12-23 09:19:18 +00:00
gh-120155: Fix copy/paste error in HAVE_SUBOFFSETS_IN_LAST_DIM() (GH-120228)
Don't hardcode 'dest' in HAVE_SUBOFFSETS_IN_LAST_DIM() macro of
memoryobject.c, but use its 'view' parameter instead.
Fix the Coverity issue:
Error: COPY_PASTE_ERROR (CWE-398):
Python-3.12.2/Objects/memoryobject.c:273:14: original: ""dest->suboffsets + (dest->ndim - 1)"" looks like the original copy.
Python-3.12.2/Objects/memoryobject.c:274:14: copy_paste_error: ""dest"" in ""src->suboffsets + (dest->ndim - 1)"" looks like a copy-paste error.
Python-3.12.2/Objects/memoryobject.c:274:14: remediation: Should it say ""src"" instead?
GH- 272| assert(dest->ndim > 0 && src->ndim > 0);
GH- 273| return (!HAVE_SUBOFFSETS_IN_LAST_DIM(dest) &&
GH- 274|-> !HAVE_SUBOFFSETS_IN_LAST_DIM(src) &&
GH- 275| dest->strides[dest->ndim-1] == dest->itemsize &&
GH- 276| src->strides[src->ndim-1] == src->itemsize);
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| clinic | ||
| mimalloc | ||
| stringlib | ||
| abstract.c | ||
| boolobject.c | ||
| bytearrayobject.c | ||
| bytes_methods.c | ||
| bytesobject.c | ||
| call.c | ||
| capsule.c | ||
| cellobject.c | ||
| classobject.c | ||
| codeobject.c | ||
| complexobject.c | ||
| descrobject.c | ||
| dictnotes.txt | ||
| dictobject.c | ||
| enumobject.c | ||
| exception_handling_notes.txt | ||
| exceptions.c | ||
| fileobject.c | ||
| floatobject.c | ||
| frame_layout.md | ||
| frameobject.c | ||
| funcobject.c | ||
| genericaliasobject.c | ||
| genobject.c | ||
| iterobject.c | ||
| listobject.c | ||
| listsort.txt | ||
| lnotab_notes.txt | ||
| locations.md | ||
| longobject.c | ||
| memoryobject.c | ||
| methodobject.c | ||
| moduleobject.c | ||
| namespaceobject.c | ||
| object.c | ||
| object_layout.md | ||
| object_layout_312.gv | ||
| object_layout_312.png | ||
| object_layout_313.gv | ||
| object_layout_313.png | ||
| object_layout_full_312.gv | ||
| object_layout_full_312.png | ||
| object_layout_full_313.gv | ||
| object_layout_full_313.png | ||
| obmalloc.c | ||
| odictobject.c | ||
| picklebufobject.c | ||
| rangeobject.c | ||
| README | ||
| setobject.c | ||
| sliceobject.c | ||
| structseq.c | ||
| tupleobject.c | ||
| typeobject.c | ||
| typeslots.inc | ||
| typeslots.py | ||
| typevarobject.c | ||
| unicodectype.c | ||
| unicodeobject.c | ||
| unicodetype_db.h | ||
| unionobject.c | ||
| weakrefobject.c | ||
Source files for various builtin objects