mirror of
https://github.com/python/cpython.git
synced 2025-07-29 06:05:00 +00:00

WarningsRecorder object. This makes the API simpler to use as no special object must be learned. Closes issue 3781. Review by Benjamin Peterson.
358 lines
15 KiB
Python
358 lines
15 KiB
Python
import unittest
|
|
import sys
|
|
from test.test_support import CleanImport, TestSkipped, run_unittest
|
|
import warnings
|
|
|
|
from contextlib import nested
|
|
|
|
if not sys.py3kwarning:
|
|
raise TestSkipped('%s must be run with the -3 flag' % __name__)
|
|
|
|
|
|
class TestPy3KWarnings(unittest.TestCase):
|
|
|
|
def assertWarning(self, _, warning, expected_message):
|
|
self.assertEqual(str(warning[-1].message), expected_message)
|
|
|
|
def test_backquote(self):
|
|
expected = 'backquote not supported in 3.x; use repr()'
|
|
with warnings.catch_warnings(record=True) as w:
|
|
exec "`2`" in {}
|
|
self.assertWarning(None, w, expected)
|
|
|
|
def test_bool_assign(self):
|
|
# So we don't screw up our globals
|
|
def safe_exec(expr):
|
|
def f(**kwargs): pass
|
|
exec expr in {'f' : f}
|
|
|
|
expected = "assignment to True or False is forbidden in 3.x"
|
|
with warnings.catch_warnings(record=True) as w:
|
|
safe_exec("True = False")
|
|
self.assertWarning(None, w, expected)
|
|
safe_exec("False = True")
|
|
self.assertWarning(None, w, expected)
|
|
try:
|
|
safe_exec("obj.False = True")
|
|
except NameError: pass
|
|
self.assertWarning(None, w, expected)
|
|
try:
|
|
safe_exec("obj.True = False")
|
|
except NameError: pass
|
|
self.assertWarning(None, w, expected)
|
|
safe_exec("def False(): pass")
|
|
self.assertWarning(None, w, expected)
|
|
safe_exec("def True(): pass")
|
|
self.assertWarning(None, w, expected)
|
|
safe_exec("class False: pass")
|
|
self.assertWarning(None, w, expected)
|
|
safe_exec("class True: pass")
|
|
self.assertWarning(None, w, expected)
|
|
safe_exec("def f(True=43): pass")
|
|
self.assertWarning(None, w, expected)
|
|
safe_exec("def f(False=None): pass")
|
|
self.assertWarning(None, w, expected)
|
|
safe_exec("f(False=True)")
|
|
self.assertWarning(None, w, expected)
|
|
safe_exec("f(True=1)")
|
|
self.assertWarning(None, w, expected)
|
|
|
|
|
|
def test_type_inequality_comparisons(self):
|
|
expected = 'type inequality comparisons not supported in 3.x'
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning(int < str, w, expected)
|
|
self.assertWarning(type < object, w, expected)
|
|
|
|
def test_object_inequality_comparisons(self):
|
|
expected = 'comparing unequal types not supported in 3.x'
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning(str < [], w, expected)
|
|
self.assertWarning(object() < (1, 2), w, expected)
|
|
|
|
def test_dict_inequality_comparisons(self):
|
|
expected = 'dict inequality comparisons not supported in 3.x'
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning({} < {2:3}, w, expected)
|
|
self.assertWarning({} <= {}, w, expected)
|
|
self.assertWarning({} > {2:3}, w, expected)
|
|
self.assertWarning({2:3} >= {}, w, expected)
|
|
|
|
def test_cell_inequality_comparisons(self):
|
|
expected = 'cell comparisons not supported in 3.x'
|
|
def f(x):
|
|
def g():
|
|
return x
|
|
return g
|
|
cell0, = f(0).func_closure
|
|
cell1, = f(1).func_closure
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning(cell0 == cell1, w, expected)
|
|
self.assertWarning(cell0 < cell1, w, expected)
|
|
|
|
def test_code_inequality_comparisons(self):
|
|
expected = 'code inequality comparisons not supported in 3.x'
|
|
def f(x):
|
|
pass
|
|
def g(x):
|
|
pass
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning(f.func_code < g.func_code, w, expected)
|
|
self.assertWarning(f.func_code <= g.func_code, w, expected)
|
|
self.assertWarning(f.func_code >= g.func_code, w, expected)
|
|
self.assertWarning(f.func_code > g.func_code, w, expected)
|
|
|
|
def test_builtin_function_or_method_comparisons(self):
|
|
expected = ('builtin_function_or_method '
|
|
'inequality comparisons not supported in 3.x')
|
|
func = eval
|
|
meth = {}.get
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning(func < meth, w, expected)
|
|
self.assertWarning(func > meth, w, expected)
|
|
self.assertWarning(meth <= func, w, expected)
|
|
self.assertWarning(meth >= func, w, expected)
|
|
|
|
def test_sort_cmp_arg(self):
|
|
expected = "the cmp argument is not supported in 3.x"
|
|
lst = range(5)
|
|
cmp = lambda x,y: -1
|
|
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning(lst.sort(cmp=cmp), w, expected)
|
|
self.assertWarning(sorted(lst, cmp=cmp), w, expected)
|
|
self.assertWarning(lst.sort(cmp), w, expected)
|
|
self.assertWarning(sorted(lst, cmp), w, expected)
|
|
|
|
def test_sys_exc_clear(self):
|
|
expected = 'sys.exc_clear() not supported in 3.x; use except clauses'
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning(sys.exc_clear(), w, expected)
|
|
|
|
def test_methods_members(self):
|
|
expected = '__members__ and __methods__ not supported in 3.x'
|
|
class C:
|
|
__methods__ = ['a']
|
|
__members__ = ['b']
|
|
c = C()
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning(dir(c), w, expected)
|
|
|
|
def test_softspace(self):
|
|
expected = 'file.softspace not supported in 3.x'
|
|
with file(__file__) as f:
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning(f.softspace, w, expected)
|
|
def set():
|
|
f.softspace = 0
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning(set(), w, expected)
|
|
|
|
def test_slice_methods(self):
|
|
class Spam(object):
|
|
def __getslice__(self, i, j): pass
|
|
def __setslice__(self, i, j, what): pass
|
|
def __delslice__(self, i, j): pass
|
|
class Egg:
|
|
def __getslice__(self, i, h): pass
|
|
def __setslice__(self, i, j, what): pass
|
|
def __delslice__(self, i, j): pass
|
|
|
|
expected = "in 3.x, __{0}slice__ has been removed; use __{0}item__"
|
|
|
|
for obj in (Spam(), Egg()):
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning(obj[1:2], w, expected.format('get'))
|
|
del obj[3:4]
|
|
self.assertWarning(None, w, expected.format('del'))
|
|
obj[4:5] = "eggs"
|
|
self.assertWarning(None, w, expected.format('set'))
|
|
|
|
def test_tuple_parameter_unpacking(self):
|
|
expected = "tuple parameter unpacking has been removed in 3.x"
|
|
with warnings.catch_warnings(record=True) as w:
|
|
exec "def f((a, b)): pass"
|
|
self.assertWarning(None, w, expected)
|
|
|
|
def test_buffer(self):
|
|
expected = 'buffer() not supported in 3.x'
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning(buffer('a'), w, expected)
|
|
|
|
def test_file_xreadlines(self):
|
|
expected = ("f.xreadlines() not supported in 3.x, "
|
|
"try 'for line in f' instead")
|
|
with file(__file__) as f:
|
|
with warnings.catch_warnings(record=True) as w:
|
|
self.assertWarning(f.xreadlines(), w, expected)
|
|
|
|
def test_hash_inheritance(self):
|
|
with warnings.catch_warnings(record=True) as w:
|
|
# With object as the base class
|
|
class WarnOnlyCmp(object):
|
|
def __cmp__(self, other): pass
|
|
self.assertEqual(len(w), 1)
|
|
self.assertWarning(None, w,
|
|
"Overriding __cmp__ blocks inheritance of __hash__ in 3.x")
|
|
del w[:]
|
|
class WarnOnlyEq(object):
|
|
def __eq__(self, other): pass
|
|
self.assertEqual(len(w), 1)
|
|
self.assertWarning(None, w,
|
|
"Overriding __eq__ blocks inheritance of __hash__ in 3.x")
|
|
del w[:]
|
|
class WarnCmpAndEq(object):
|
|
def __cmp__(self, other): pass
|
|
def __eq__(self, other): pass
|
|
self.assertEqual(len(w), 2)
|
|
self.assertWarning(None, w[:1],
|
|
"Overriding __cmp__ blocks inheritance of __hash__ in 3.x")
|
|
self.assertWarning(None, w,
|
|
"Overriding __eq__ blocks inheritance of __hash__ in 3.x")
|
|
del w[:]
|
|
class NoWarningOnlyHash(object):
|
|
def __hash__(self): pass
|
|
self.assertEqual(len(w), 0)
|
|
del w[:]
|
|
# With an intermediate class in the heirarchy
|
|
class DefinesAllThree(object):
|
|
def __cmp__(self, other): pass
|
|
def __eq__(self, other): pass
|
|
def __hash__(self): pass
|
|
class WarnOnlyCmp(DefinesAllThree):
|
|
def __cmp__(self, other): pass
|
|
self.assertEqual(len(w), 1)
|
|
self.assertWarning(None, w,
|
|
"Overriding __cmp__ blocks inheritance of __hash__ in 3.x")
|
|
del w[:]
|
|
class WarnOnlyEq(DefinesAllThree):
|
|
def __eq__(self, other): pass
|
|
self.assertEqual(len(w), 1)
|
|
self.assertWarning(None, w,
|
|
"Overriding __eq__ blocks inheritance of __hash__ in 3.x")
|
|
del w[:]
|
|
class WarnCmpAndEq(DefinesAllThree):
|
|
def __cmp__(self, other): pass
|
|
def __eq__(self, other): pass
|
|
self.assertEqual(len(w), 2)
|
|
self.assertWarning(None, w[:1],
|
|
"Overriding __cmp__ blocks inheritance of __hash__ in 3.x")
|
|
self.assertWarning(None, w,
|
|
"Overriding __eq__ blocks inheritance of __hash__ in 3.x")
|
|
del w[:]
|
|
class NoWarningOnlyHash(DefinesAllThree):
|
|
def __hash__(self): pass
|
|
self.assertEqual(len(w), 0)
|
|
|
|
|
|
class TestStdlibRemovals(unittest.TestCase):
|
|
|
|
# test.testall not tested as it executes all unit tests as an
|
|
# import side-effect.
|
|
all_platforms = ('audiodev', 'imputil', 'mutex', 'user', 'new', 'rexec',
|
|
'Bastion', 'compiler', 'dircache', 'mimetools',
|
|
'fpformat', 'ihooks', 'mhlib', 'statvfs', 'htmllib',
|
|
'sgmllib', 'rfc822', 'sunaudio')
|
|
inclusive_platforms = {'irix' : ('pure', 'AL', 'al', 'CD', 'cd', 'cddb',
|
|
'cdplayer', 'CL', 'cl', 'DEVICE', 'GL',
|
|
'gl', 'ERRNO', 'FILE', 'FL', 'flp', 'fl',
|
|
'fm', 'GET', 'GLWS', 'imgfile', 'IN',
|
|
'IOCTL', 'jpeg', 'panel', 'panelparser',
|
|
'readcd', 'SV', 'torgb', 'WAIT'),
|
|
'darwin' : ('autoGIL', 'Carbon', 'OSATerminology',
|
|
'icglue', 'Nav', 'MacOS', 'aepack',
|
|
'aetools', 'aetypes', 'applesingle',
|
|
'appletrawmain', 'appletrunner',
|
|
'argvemulator', 'bgenlocations',
|
|
'EasyDialogs', 'macerrors', 'macostools',
|
|
'findertools', 'FrameWork', 'ic',
|
|
'gensuitemodule', 'icopen', 'macresource',
|
|
'MiniAEFrame', 'pimp', 'PixMapWrapper',
|
|
'terminalcommand', 'videoreader',
|
|
'_builtinSuites', 'CodeWarrior',
|
|
'Explorer', 'Finder', 'Netscape',
|
|
'StdSuites', 'SystemEvents', 'Terminal',
|
|
'cfmfile', 'bundlebuilder', 'buildtools',
|
|
'ColorPicker', 'Audio_mac'),
|
|
'sunos5' : ('sunaudiodev', 'SUNAUDIODEV'),
|
|
}
|
|
optional_modules = ('bsddb185', 'Canvas', 'dl', 'linuxaudiodev', 'imageop',
|
|
'sv', 'cPickle', 'bsddb', 'dbhash')
|
|
|
|
def check_removal(self, module_name, optional=False):
|
|
"""Make sure the specified module, when imported, raises a
|
|
DeprecationWarning and specifies itself in the message."""
|
|
with nested(CleanImport(module_name), warnings.catch_warnings()):
|
|
warnings.filterwarnings("error", ".+ removed",
|
|
DeprecationWarning, __name__)
|
|
try:
|
|
__import__(module_name, level=0)
|
|
except DeprecationWarning as exc:
|
|
self.assert_(module_name in exc.args[0],
|
|
"%s warning didn't contain module name"
|
|
% module_name)
|
|
except ImportError:
|
|
if not optional:
|
|
self.fail("Non-optional module {0} raised an "
|
|
"ImportError.".format(module_name))
|
|
else:
|
|
self.fail("DeprecationWarning not raised for {0}"
|
|
.format(module_name))
|
|
|
|
def test_platform_independent_removals(self):
|
|
# Make sure that the modules that are available on all platforms raise
|
|
# the proper DeprecationWarning.
|
|
for module_name in self.all_platforms:
|
|
self.check_removal(module_name)
|
|
|
|
def test_platform_specific_removals(self):
|
|
# Test the removal of platform-specific modules.
|
|
for module_name in self.inclusive_platforms.get(sys.platform, []):
|
|
self.check_removal(module_name, optional=True)
|
|
|
|
def test_optional_module_removals(self):
|
|
# Test the removal of modules that may or may not be built.
|
|
for module_name in self.optional_modules:
|
|
self.check_removal(module_name, optional=True)
|
|
|
|
def test_os_path_walk(self):
|
|
msg = "In 3.x, os.path.walk is removed in favor of os.walk."
|
|
def dumbo(where, names, args): pass
|
|
for path_mod in ("ntpath", "macpath", "os2emxpath", "posixpath"):
|
|
mod = __import__(path_mod)
|
|
with warnings.catch_warnings(record=True) as w:
|
|
mod.walk("crashers", dumbo, None)
|
|
self.assertEquals(str(w[-1].message), msg)
|
|
|
|
def test_commands_members(self):
|
|
import commands
|
|
members = {"mk2arg" : 2, "mkarg" : 1, "getstatus" : 1}
|
|
for name, arg_count in members.items():
|
|
with warnings.catch_warnings():
|
|
warnings.filterwarnings("error")
|
|
func = getattr(commands, name)
|
|
self.assertRaises(DeprecationWarning, func, *([None]*arg_count))
|
|
|
|
def test_reduce_move(self):
|
|
from operator import add
|
|
with warnings.catch_warnings():
|
|
warnings.filterwarnings("error", "reduce")
|
|
self.assertRaises(DeprecationWarning, reduce, add, range(10))
|
|
|
|
def test_mutablestring_removal(self):
|
|
# UserString.MutableString has been removed in 3.0.
|
|
import UserString
|
|
with warnings.catch_warnings():
|
|
warnings.filterwarnings("error", ".*MutableString",
|
|
DeprecationWarning)
|
|
self.assertRaises(DeprecationWarning, UserString.MutableString)
|
|
|
|
|
|
def test_main():
|
|
with warnings.catch_warnings():
|
|
warnings.simplefilter("always")
|
|
run_unittest(TestPy3KWarnings,
|
|
TestStdlibRemovals)
|
|
|
|
if __name__ == '__main__':
|
|
test_main()
|