mirror of
https://github.com/python/cpython.git
synced 2025-07-18 16:55:20 +00:00
f1827cfaab
file_truncate(): C doesn't define what fflush(fp) does if fp is open for update, and the preceding I/O operation on fp was input. On Windows, fflush() actually changes the current file position then. Because Windows doesn't support ftruncate() directly, this not only caused Python's file.truncate() to change the file position (contra our docs), it also caused the file not to change size. Repaired by getting the initial file position at the start, restoring it at the end, and tossing all the complicated micro-efficiency checks trying to avoid "provably unnecessary" seeks. file.truncate() can't be a frequent operation, and seeking to the current file position has got to be cheap anyway. Bugfix candidate.
162 lines
3.8 KiB
Python
162 lines
3.8 KiB
Python
import sys
|
|
import os
|
|
from array import array
|
|
|
|
from test.test_support import verify, TESTFN, TestFailed
|
|
from UserList import UserList
|
|
|
|
# verify expected attributes exist
|
|
f = file(TESTFN, 'w')
|
|
softspace = f.softspace
|
|
f.name # merely shouldn't blow up
|
|
f.mode # ditto
|
|
f.closed # ditto
|
|
|
|
# verify softspace is writable
|
|
f.softspace = softspace # merely shouldn't blow up
|
|
|
|
# verify the others aren't
|
|
for attr in 'name', 'mode', 'closed':
|
|
try:
|
|
setattr(f, attr, 'oops')
|
|
except TypeError:
|
|
pass
|
|
else:
|
|
raise TestFailed('expected TypeError setting file attr %r' % attr)
|
|
f.close()
|
|
|
|
# verify writelines with instance sequence
|
|
l = UserList(['1', '2'])
|
|
f = open(TESTFN, 'wb')
|
|
f.writelines(l)
|
|
f.close()
|
|
f = open(TESTFN, 'rb')
|
|
buf = f.read()
|
|
f.close()
|
|
verify(buf == '12')
|
|
|
|
# verify readinto
|
|
a = array('c', 'x'*10)
|
|
f = open(TESTFN, 'rb')
|
|
n = f.readinto(a)
|
|
f.close()
|
|
verify(buf == a.tostring()[:n])
|
|
|
|
# verify writelines with integers
|
|
f = open(TESTFN, 'wb')
|
|
try:
|
|
f.writelines([1, 2, 3])
|
|
except TypeError:
|
|
pass
|
|
else:
|
|
print "writelines accepted sequence of integers"
|
|
f.close()
|
|
|
|
# verify writelines with integers in UserList
|
|
f = open(TESTFN, 'wb')
|
|
l = UserList([1,2,3])
|
|
try:
|
|
f.writelines(l)
|
|
except TypeError:
|
|
pass
|
|
else:
|
|
print "writelines accepted sequence of integers"
|
|
f.close()
|
|
|
|
# verify writelines with non-string object
|
|
class NonString: pass
|
|
|
|
f = open(TESTFN, 'wb')
|
|
try:
|
|
f.writelines([NonString(), NonString()])
|
|
except TypeError:
|
|
pass
|
|
else:
|
|
print "writelines accepted sequence of non-string objects"
|
|
f.close()
|
|
|
|
# verify that we get a sensible error message for bad mode argument
|
|
bad_mode = "qwerty"
|
|
try:
|
|
open(TESTFN, bad_mode)
|
|
except IOError, msg:
|
|
if msg[0] != 0:
|
|
s = str(msg)
|
|
if s.find(TESTFN) != -1 or s.find(bad_mode) == -1:
|
|
print "bad error message for invalid mode: %s" % s
|
|
# if msg[0] == 0, we're probably on Windows where there may be
|
|
# no obvious way to discover why open() failed.
|
|
else:
|
|
print "no error for invalid mode: %s" % bad_mode
|
|
|
|
f = open(TESTFN)
|
|
if f.name != TESTFN:
|
|
raise TestFailed, 'file.name should be "%s"' % TESTFN
|
|
if f.isatty():
|
|
raise TestFailed, 'file.isatty() should be false'
|
|
|
|
if f.closed:
|
|
raise TestFailed, 'file.closed should be false'
|
|
|
|
try:
|
|
f.readinto("")
|
|
except TypeError:
|
|
pass
|
|
else:
|
|
raise TestFailed, 'file.readinto("") should raise a TypeError'
|
|
|
|
f.close()
|
|
if not f.closed:
|
|
raise TestFailed, 'file.closed should be true'
|
|
|
|
methods = ['fileno', 'flush', 'isatty', 'next', 'read', 'readinto',
|
|
'readline', 'readlines', 'seek', 'tell', 'truncate', 'write',
|
|
'xreadlines', '__iter__']
|
|
if sys.platform.startswith('atheos'):
|
|
methods.remove('truncate')
|
|
|
|
for methodname in methods:
|
|
method = getattr(f, methodname)
|
|
try:
|
|
method()
|
|
except ValueError:
|
|
pass
|
|
else:
|
|
raise TestFailed, 'file.%s() on a closed file should raise a ValueError' % methodname
|
|
|
|
try:
|
|
f.writelines([])
|
|
except ValueError:
|
|
pass
|
|
else:
|
|
raise TestFailed, 'file.writelines([]) on a closed file should raise a ValueError'
|
|
|
|
os.unlink(TESTFN)
|
|
|
|
def bug801631():
|
|
# SF bug <http://www.python.org/sf/801631>
|
|
# "file.truncate fault on windows"
|
|
f = file(TESTFN, 'wb')
|
|
f.write('12345678901') # 11 bytes
|
|
f.close()
|
|
|
|
f = file(TESTFN,'rb+')
|
|
data = f.read(5)
|
|
if data != '12345':
|
|
raise TestFailed("Read on file opened for update failed %r" % data)
|
|
if f.tell() != 5:
|
|
raise TestFailed("File pos after read wrong %d" % f.tell())
|
|
|
|
f.truncate()
|
|
if f.tell() != 5:
|
|
raise TestFailed("File pos after ftruncate wrong %d" % f.tell())
|
|
|
|
f.close()
|
|
size = os.path.getsize(TESTFN)
|
|
if size != 5:
|
|
raise TestFailed("File size after ftruncate wrong %d" % size)
|
|
|
|
try:
|
|
bug801631()
|
|
finally:
|
|
os.unlink(TESTFN)
|