mirrors/datafusion-sqlparse
1
0
Fork 0
mirror of https://github.com/apache/datafusion-sqlparser-rs.git synced 2025-07-07 17:04:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Parse INSERT with subquery when lacking column names (#1586)

Browse source
This commit is contained in:
Ifeanyi Ubah 2024-12-11 23:31:24 +01:00 • committed by GitHub
parent 00abaf2187
commit 04271b0e4e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 21 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

25
src/parser/mod.rs
View file

@ -11329,14 +11329,19 @@ impl<'a> Parser<'a> {
if self.parse_keywords(&[Keyword::DEFAULT, Keyword::VALUES]) {
(vec![], None, vec![], None)
} else {
let columns = self.parse_parenthesized_column_list(Optional, is_mysql)?;
let (columns, partitioned, after_columns) = if !self.peek_subquery_start() {
let columns = self.parse_parenthesized_column_list(Optional, is_mysql)?;
let partitioned = self.parse_insert_partition()?;
// Hive allows you to specify columns after partitions as well if you want.
let after_columns = if dialect_of!(self is HiveDialect) {
self.parse_parenthesized_column_list(Optional, false)?
let partitioned = self.parse_insert_partition()?;
// Hive allows you to specify columns after partitions as well if you want.
let after_columns = if dialect_of!(self is HiveDialect) {
self.parse_parenthesized_column_list(Optional, false)?
} else {
vec![]
};
(columns, partitioned, after_columns)
} else {
vec![]
Default::default()
};
let source = Some(self.parse_query()?);
@ -11431,6 +11436,14 @@ impl<'a> Parser<'a> {
}
}
/// Returns true if the immediate tokens look like the
/// beginning of a subquery. `(SELECT ...`
fn peek_subquery_start(&mut self) -> bool {
let [maybe_lparen, maybe_select] = self.peek_tokens();
Token::LParen == maybe_lparen
&& matches!(maybe_select, Token::Word(w) if w.keyword == Keyword::SELECT)
}
fn parse_conflict_clause(&mut self) -> Option<SqliteOnConflict> {
if self.parse_keywords(&[Keyword::OR, Keyword::REPLACE]) {
Some(SqliteOnConflict::Replace)

2
tests/sqlparser_common.rs
View file

@ -10964,6 +10964,8 @@ fn insert_into_with_parentheses() {
Box::new(GenericDialect {}),
]);
dialects.verified_stmt("INSERT INTO t1 (id, name) (SELECT t2.id, t2.name FROM t2)");
dialects.verified_stmt("INSERT INTO t1 (SELECT t2.id, t2.name FROM t2)");
dialects.verified_stmt(r#"INSERT INTO t1 ("select", name) (SELECT t2.name FROM t2)"#);
}
#[test]