mirrors/datafusion-sqlparse
1
0
Fork 0
mirror of https://github.com/apache/datafusion-sqlparser-rs.git synced 2025-10-09 21:42:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix: use Rust idiomatic capitalization for newly added DataType enums (#939)

Browse source
This commit is contained in:
Kikkon 2023-08-07 22:55:42 +08:00 • committed by GitHub
parent eb4be98980
commit 173a6db818
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/ast/data_type.rs
View file

@ -145,16 +145,16 @@ pub enum DataType {
Int8(Option<u64>), Int8(Option<u64>),
/// Unsigned Int8 with optional display width e.g. INT8 UNSIGNED or INT8(11) UNSIGNED /// Unsigned Int8 with optional display width e.g. INT8 UNSIGNED or INT8(11) UNSIGNED
UnsignedInt8(Option<u64>), UnsignedInt8(Option<u64>),
/// FLOAT4 as alias for Real in [postgresql] /// Float4 as alias for Real in [postgresql]
/// ///
/// [postgresql]: https://www.postgresql.org/docs/15/datatype.html /// [postgresql]: https://www.postgresql.org/docs/15/datatype.html
FLOAT4, Float4,
/// Floating point e.g. REAL /// Floating point e.g. REAL
Real, Real,
/// FLOAT8 as alias for Double in [postgresql] /// Float8 as alias for Double in [postgresql]
/// ///
/// [postgresql]: https://www.postgresql.org/docs/15/datatype.html /// [postgresql]: https://www.postgresql.org/docs/15/datatype.html
FLOAT8, Float8,
/// Double /// Double
Double, Double,
/// Double PRECISION e.g. [standard], [postgresql] /// Double PRECISION e.g. [standard], [postgresql]
@ -296,9 +296,9 @@ impl fmt::Display for DataType {
format_type_with_optional_length(f, "INT8", zerofill, true) format_type_with_optional_length(f, "INT8", zerofill, true)
} }
DataType::Real => write!(f, "REAL"), DataType::Real => write!(f, "REAL"),
DataType::FLOAT4 => write!(f, "FLOAT4"), DataType::Float4 => write!(f, "FLOAT4"),
DataType::Double => write!(f, "DOUBLE"), DataType::Double => write!(f, "DOUBLE"),
DataType::FLOAT8 => write!(f, "FLOAT8"), DataType::Float8 => write!(f, "FLOAT8"),
DataType::DoublePrecision => write!(f, "DOUBLE PRECISION"), DataType::DoublePrecision => write!(f, "DOUBLE PRECISION"),
DataType::Bool => write!(f, "BOOL"), DataType::Bool => write!(f, "BOOL"),
DataType::Boolean => write!(f, "BOOLEAN"), DataType::Boolean => write!(f, "BOOLEAN"),

4
src/parser.rs
View file

@ -4568,8 +4568,8 @@ impl<'a> Parser<'a> {
Keyword::BOOL => Ok(DataType::Bool), Keyword::BOOL => Ok(DataType::Bool),
Keyword::FLOAT => Ok(DataType::Float(self.parse_optional_precision()?)), Keyword::FLOAT => Ok(DataType::Float(self.parse_optional_precision()?)),
Keyword::REAL => Ok(DataType::Real), Keyword::REAL => Ok(DataType::Real),
Keyword::FLOAT4 => Ok(DataType::FLOAT4), Keyword::FLOAT4 => Ok(DataType::Float4),
Keyword::FLOAT8 => Ok(DataType::FLOAT8), Keyword::FLOAT8 => Ok(DataType::Float8),
Keyword::DOUBLE => { Keyword::DOUBLE => {
if self.parse_keyword(Keyword::PRECISION) { if self.parse_keyword(Keyword::PRECISION) {
Ok(DataType::DoublePrecision) Ok(DataType::DoublePrecision)

4
tests/sqlparser_postgres.rs
View file

@ -2993,13 +2993,13 @@ fn parse_create_table_with_alias() {
}, },
ColumnDef { ColumnDef {
name: "float8_col".into(), name: "float8_col".into(),
data_type: DataType::FLOAT8, data_type: DataType::Float8,
collation: None, collation: None,
options: vec![] options: vec![]
}, },
ColumnDef { ColumnDef {
name: "float4_col".into(), name: "float4_col".into(),
data_type: DataType::FLOAT4, data_type: DataType::Float4,
collation: None, collation: None,
options: vec![] options: vec![]
}, },