diff --git a/src/ast/mod.rs b/src/ast/mod.rs index 462dae51..857f6b35 100644 --- a/src/ast/mod.rs +++ b/src/ast/mod.rs @@ -993,16 +993,16 @@ impl fmt::Display for Statement { } match hive_distribution { HiveDistributionStyle::PARTITIONED { columns } => { - write!(f, " PARTITIONED BY ({})", display_comma_separated(&columns))?; + write!(f, " PARTITIONED BY ({})", display_comma_separated(columns))?; } HiveDistributionStyle::CLUSTERED { columns, sorted_by, num_buckets, } => { - write!(f, " CLUSTERED BY ({})", display_comma_separated(&columns))?; + write!(f, " CLUSTERED BY ({})", display_comma_separated(columns))?; if !sorted_by.is_empty() { - write!(f, " SORTED BY ({})", display_comma_separated(&sorted_by))?; + write!(f, " SORTED BY ({})", display_comma_separated(sorted_by))?; } if *num_buckets > 0 { write!(f, " INTO {} BUCKETS", num_buckets)?; @@ -1016,8 +1016,8 @@ impl fmt::Display for Statement { write!( f, " SKEWED BY ({})) ON ({})", - display_comma_separated(&columns), - display_comma_separated(&on) + display_comma_separated(columns), + display_comma_separated(on) )?; if *stored_as_directories { write!(f, " STORED AS DIRECTORIES")?; diff --git a/src/parser.rs b/src/parser.rs index 990df678..76ccc86d 100644 --- a/src/parser.rs +++ b/src/parser.rs @@ -102,7 +102,7 @@ impl<'a> Parser<'a> { /// Parse a SQL statement and produce an Abstract Syntax Tree (AST) pub fn parse_sql(dialect: &dyn Dialect, sql: &str) -> Result, ParserError> { - let mut tokenizer = Tokenizer::new(dialect, &sql); + let mut tokenizer = Tokenizer::new(dialect, sql); let tokens = tokenizer.tokenize()?; let mut parser = Parser::new(tokens, dialect); let mut stmts = Vec::new(); diff --git a/src/test_utils.rs b/src/test_utils.rs index 160d2c11..eb99b4f7 100644 --- a/src/test_utils.rs +++ b/src/test_utils.rs @@ -64,7 +64,7 @@ impl TestedDialects { } pub fn parse_sql_statements(&self, sql: &str) -> Result, ParserError> { - self.one_of_identical_results(|dialect| Parser::parse_sql(dialect, &sql)) + self.one_of_identical_results(|dialect| Parser::parse_sql(dialect, sql)) // To fail the `ensure_multiple_dialects_are_tested` test: // Parser::parse_sql(&**self.dialects.first().unwrap(), sql) } @@ -75,11 +75,11 @@ impl TestedDialects { /// tree as parsing `canonical`, and that serializing it back to string /// results in the `canonical` representation. pub fn one_statement_parses_to(&self, sql: &str, canonical: &str) -> Statement { - let mut statements = self.parse_sql_statements(&sql).unwrap(); + let mut statements = self.parse_sql_statements(sql).unwrap(); assert_eq!(statements.len(), 1); if !canonical.is_empty() && sql != canonical { - assert_eq!(self.parse_sql_statements(&canonical).unwrap(), statements); + assert_eq!(self.parse_sql_statements(canonical).unwrap(), statements); } let only_statement = statements.pop().unwrap();