Code review feedback

This commit is contained in:
Yoav Cohen 2025-08-12 12:58:38 +02:00
parent cdba47471f
commit 43b9f45102
3 changed files with 55 additions and 19 deletions

View file

@ -16731,7 +16731,7 @@ fn parse_create_table_like() {
}
#[test]
fn pares_copy_options() {
fn parse_copy_options() {
let copy = verified_stmt(
r#"COPY dst (c1, c2, c3) FROM 's3://redshift-downloads/tickit/category_pipe.txt' IAM_ROLE 'arn:aws:iam::123456789:role/role1' CSV IGNOREHEADER 1"#,
);
@ -16740,7 +16740,7 @@ fn pares_copy_options() {
assert_eq!(
legacy_options,
vec![
CopyLegacyOption::IamRole(Some(
CopyLegacyOption::IamRole(IamRoleKind::Arn(
"arn:aws:iam::123456789:role/role1".to_string()
)),
CopyLegacyOption::Csv(vec![]),
@ -16750,4 +16750,22 @@ fn pares_copy_options() {
}
_ => unreachable!(),
}
let copy = one_statement_parses_to(
r#"COPY dst (c1, c2, c3) FROM 's3://redshift-downloads/tickit/category_pipe.txt' IAM_ROLE DEFAULT CSV IGNOREHEADER AS 1"#,
r#"COPY dst (c1, c2, c3) FROM 's3://redshift-downloads/tickit/category_pipe.txt' IAM_ROLE DEFAULT CSV IGNOREHEADER 1"#,
);
match copy {
Statement::Copy { legacy_options, .. } => {
assert_eq!(
legacy_options,
vec![
CopyLegacyOption::IamRole(IamRoleKind::Default),
CopyLegacyOption::Csv(vec![]),
CopyLegacyOption::IgnoreHeader(1),
]
);
}
_ => unreachable!(),
}
}