Remove most instances of #[cfg(feature(bigdecimal))] in tests (#910)

src/ast/value.rs

@@ -32,6 +32,9 @@ pub enum Value {
     #[cfg(not(feature = "bigdecimal"))]
     Number(String, bool),
     #[cfg(feature = "bigdecimal")]
+    // HINT: use `test_utils::number` to make an instance of
+    // Value::Number This might help if you your tests pass locally
+    // but fail on CI with the `--all-features` flag enabled
     Number(BigDecimal, bool),
     /// 'string value'
     SingleQuotedString(String),

src/test_utils.rs

@@ -198,7 +198,7 @@ pub fn expr_from_projection(item: &SelectItem) -> &Expr {
 }
 
 /// Creates a `Value::Number`, panic'ing if n is not a number
-pub fn number(n: &'static str) -> Value {
+pub fn number(n: &str) -> Value {
     Value::Number(n.parse().unwrap(), false)
 }