mirrors/datafusion-sqlparse
1
0
Fork 0
mirror of https://github.com/apache/datafusion-sqlparser-rs.git synced 2025-09-04 21:20:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix precedence of unary NOT

Browse source 
get_next_precedence deals with left-binding power, not right binding
power. Therefore, when it encounters a standalone NOT operator (i.e., a
"NOT" token that is not followed by "BETWEEN", "LIKE", or "IN"), it
should return 0, because unary NOT is not an infix operator, it's a
prefix operator, and therefore it has no left-binding power.
This commit is contained in:
Nikhil Benesch 2019-06-06 12:54:21 -04:00
parent 1f87083906
commit 525f4d7501
No known key found for this signature in database
GPG key ID: FCF98542083C5A69
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/sqlparser.rs
View file

@ -580,11 +580,12 @@ impl Parser {
// The precedence of NOT varies depending on keyword that // The precedence of NOT varies depending on keyword that
// follows it. If it is followed by IN, BETWEEN, or LIKE, // follows it. If it is followed by IN, BETWEEN, or LIKE,
// it takes on the precedence of those tokens. Otherwise it // it takes on the precedence of those tokens. Otherwise it
// takes on UNARY_NOT_PREC. // is not an infix operator, and therefore has zero
// precedence.
Some(Token::SQLWord(k)) if k.keyword == "IN" => Ok(Self::BETWEEN_PREC), Some(Token::SQLWord(k)) if k.keyword == "IN" => Ok(Self::BETWEEN_PREC),
Some(Token::SQLWord(k)) if k.keyword == "BETWEEN" => Ok(Self::BETWEEN_PREC), Some(Token::SQLWord(k)) if k.keyword == "BETWEEN" => Ok(Self::BETWEEN_PREC),
Some(Token::SQLWord(k)) if k.keyword == "LIKE" => Ok(Self::BETWEEN_PREC), Some(Token::SQLWord(k)) if k.keyword == "LIKE" => Ok(Self::BETWEEN_PREC),
_ => Ok(Self::UNARY_NOT_PREC), _ => Ok(0),
}, },
Token::SQLWord(k) if k.keyword == "IS" => Ok(17), Token::SQLWord(k) if k.keyword == "IS" => Ok(17),
Token::SQLWord(k) if k.keyword == "IN" => Ok(Self::BETWEEN_PREC), Token::SQLWord(k) if k.keyword == "IN" => Ok(Self::BETWEEN_PREC),

2
tests/sqlparser_common.rs
View file

@ -352,7 +352,7 @@ fn parse_not() {
fn parse_invalid_infix_not() { fn parse_invalid_infix_not() {
let res = parse_sql_statements("SELECT c FROM t WHERE c NOT ("); let res = parse_sql_statements("SELECT c FROM t WHERE c NOT (");
assert_eq!( assert_eq!(
ParserError::ParserError("Expected IN or BETWEEN after NOT, found: (".to_string()), ParserError::ParserError("Expected end of statement, found: NOT".to_string()),
res.unwrap_err(), res.unwrap_err(),
); );
} }