mirrors/datafusion-sqlparse
1
0
Fork 0
mirror of https://github.com/apache/datafusion-sqlparser-rs.git synced 2025-08-23 15:34:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

feat: support tailing commas on snowflake dialect. (#1205)

Browse source
This commit is contained in:
yassun7010 2024-04-10 05:19:27 +09:00 • committed by GitHub
parent 17ef71e42b
commit 6da8828c1b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/parser/mod.rs
View file

@ -2946,14 +2946,15 @@ impl<'a> Parser<'a> {
/// Parse a comma-separated list of 1+ SelectItem
pub fn parse_projection(&mut self) -> Result<Vec<SelectItem>, ParserError> {
// BigQuery allows trailing commas, but only in project lists
// BigQuery and Snowflake allow trailing commas, but only in project lists
// e.g. `SELECT 1, 2, FROM t`
// https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#trailing_commas
// https://docs.snowflake.com/en/release-notes/2024/8_11#select-supports-trailing-commas
//
// This pattern could be captured better with RAII type semantics, but it's quite a bit of
// code to add for just one case, so we'll just do it manually here.
let old_value = self.options.trailing_commas;
self.options.trailing_commas |= dialect_of!(self is BigQueryDialect);
self.options.trailing_commas |= dialect_of!(self is BigQueryDialect | SnowflakeDialect);
let ret = self.parse_comma_separated(|p| p.parse_select_item());
self.options.trailing_commas = old_value;

5
tests/sqlparser_snowflake.rs
View file

@ -1536,3 +1536,8 @@ fn parse_comma_outer_join() {
"SELECT t1.c1, t2.c2 FROM t1, t2 WHERE t1.c1 = t2.c2 (+)",
);
}
#[test]
fn test_sf_trailing_commas() {
snowflake().verified_only_select_with_canonical("SELECT 1, 2, FROM t", "SELECT 1, 2 FROM t");
}