mirrors/datafusion-sqlparse
1
0
Fork 0
mirror of https://github.com/apache/datafusion-sqlparser-rs.git synced 2025-09-27 16:09:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

MySQL dialect: Add support for hash comments (#1466)

Browse source
This commit is contained in:
Hans Ott 2024-10-11 17:15:18 +02:00 • committed by GitHub
parent a4fa9e08b7
commit 749b061fbf
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/tokenizer.rs
View file

@ -43,7 +43,8 @@ use sqlparser_derive::{Visit, VisitMut};
use crate::ast::DollarQuotedString; use crate::ast::DollarQuotedString;
use crate::dialect::Dialect; use crate::dialect::Dialect;
use crate::dialect::{ use crate::dialect::{
BigQueryDialect, DuckDbDialect, GenericDialect, PostgreSqlDialect, SnowflakeDialect, BigQueryDialect, DuckDbDialect, GenericDialect, MySqlDialect, PostgreSqlDialect,
SnowflakeDialect,
}; };
use crate::keywords::{Keyword, ALL_KEYWORDS, ALL_KEYWORDS_INDEX}; use crate::keywords::{Keyword, ALL_KEYWORDS, ALL_KEYWORDS_INDEX};
@ -1140,7 +1141,7 @@ impl<'a> Tokenizer<'a> {
} }
'{' => self.consume_and_return(chars, Token::LBrace), '{' => self.consume_and_return(chars, Token::LBrace),
'}' => self.consume_and_return(chars, Token::RBrace), '}' => self.consume_and_return(chars, Token::RBrace),
'#' if dialect_of!(self is SnowflakeDialect | BigQueryDialect) => { '#' if dialect_of!(self is SnowflakeDialect | BigQueryDialect | MySqlDialect) => {
chars.next(); // consume the '#', starting a snowflake single-line comment chars.next(); // consume the '#', starting a snowflake single-line comment
let comment = self.tokenize_single_line_comment(chars); let comment = self.tokenize_single_line_comment(chars);
Ok(Some(Token::Whitespace(Whitespace::SingleLineComment { Ok(Some(Token::Whitespace(Whitespace::SingleLineComment {

6
tests/sqlparser_common.rs
View file

@ -9923,7 +9923,11 @@ fn test_release_savepoint() {
#[test] #[test]
fn test_comment_hash_syntax() { fn test_comment_hash_syntax() {
let dialects = TestedDialects { let dialects = TestedDialects {
dialects: vec![Box::new(BigQueryDialect {}), Box::new(SnowflakeDialect {})], dialects: vec![
Box::new(BigQueryDialect {}),
Box::new(SnowflakeDialect {}),
Box::new(MySqlDialect {}),
],
options: None, options: None,
}; };
let sql = r#" let sql = r#"