mirrors/datafusion-sqlparse
1
0
Fork 0
mirror of https://github.com/apache/datafusion-sqlparser-rs.git synced 2025-08-04 14:28:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix table alias parsing regression in 0.31.0 by backing out redshift column definition list (#827)

Browse source 
* Fix table alias parsing regression

* Revert "Support redshift's columns definition list for system information functions (#769)"

This reverts commit c35dcc93a7.
This commit is contained in:
Andrew Lamb 2023-03-06 17:43:22 +01:00 • committed by GitHub
parent d69b875367
commit 7f4c9132d7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
14 changed files with 37 additions and 194 deletions
Download patch file Download diff file Expand all files Collapse all files

73
tests/sqlparser_redshift.rs
View file

@ -44,7 +44,6 @@ fn test_square_brackets_over_db_schema_table_name() {
]),
alias: None,
args: None,
columns_definition: None,
with_hints: vec![],
},
joins: vec![],
@ -89,7 +88,6 @@ fn test_double_quotes_over_db_schema_table_name() {
]),
alias: None,
args: None,
columns_definition: None,
with_hints: vec![],
},
joins: vec![],
@ -109,13 +107,11 @@ fn parse_delimited_identifiers() {
name,
alias,
args,
columns_definition,
with_hints,
} => {
assert_eq!(vec![Ident::with_quote('"', "a table")], name.0);
assert_eq!(Ident::with_quote('"', "alias"), alias.unwrap().name);
assert!(args.is_none());
assert!(columns_definition.is_none());
assert!(with_hints.is_empty());
}
_ => panic!("Expecting TableFactor::Table"),
@ -276,72 +272,3 @@ fn test_sharp() {
select.projection[0]
);
}
#[test]
fn test_parse_pg_get_late_binding_view_cols() {
let sql = "select * from pg_get_late_binding_view_cols() some_name_cols(view_schema name, view_name name, col_name name)";
let expected = "SELECT * FROM pg_get_late_binding_view_cols() some_name_cols(view_schema name, view_name name, col_name name)";
redshift().one_statement_parses_to(sql, expected);
let select = redshift().verified_only_select(expected);
assert_eq!(
TableFactor::Table {
name: ObjectName(vec![Ident::new("pg_get_late_binding_view_cols")],),
args: Some(vec![]),
alias: None,
columns_definition: Some(TableAliasDefinition {
name: Ident::new("some_name_cols"),
args: vec![
IdentPair(Ident::new("view_schema"), Ident::new("name")),
IdentPair(Ident::new("view_name"), Ident::new("name")),
IdentPair(Ident::new("col_name"), Ident::new("name"))
]
}),
with_hints: vec![]
},
select.from[0].relation
);
}
#[test]
fn test_parse_pg_get_cols() {
let sql =
"SELECT * FROM pg_get_cols() some_name(view_schema name, view_name name, col_name name)";
redshift().verified_stmt(sql);
}
#[test]
fn test_parse_pg_get_grantee_by_iam_role() {
let sql = "SELECT grantee, grantee_type, cmd_type FROM pg_get_grantee_by_iam_role('arn:aws:iam::123456789012:role/Redshift-S3-Write') res_grantee(grantee text, grantee_type text, cmd_type text)";
redshift().verified_stmt(sql);
}
#[test]
fn test_parse_pg_get_iam_role_by_user() {
let sql = "SELECT username, iam_role, cmd FROM pg_get_iam_role_by_user('reg_user1') res_iam_role(username text, iam_role text, cmd text)";
redshift().verified_stmt(sql);
}
#[test]
fn test_parse_pg_get_late_binding_view_cols_in_select() {
let sql = "SELECT pg_get_late_binding_view_cols()";
redshift().verified_stmt(sql);
}
#[test]
fn test_parse_pg_get_cols_in_select() {
let sql = "SELECT pg_get_cols()";
redshift().verified_stmt(sql);
}
#[test]
fn test_parse_pg_get_grantee_by_iam_role_in_select() {
let sql = "SELECT pg_get_grantee_by_iam_role()";
redshift().verified_stmt(sql);
}
#[test]
fn test_parse_pg_get_iam_role_by_user_in_select() {
let sql = "SELECT pg_get_iam_role_by_user()";
redshift().verified_stmt(sql);
}