mirrors/datafusion-sqlparse
1
0
Fork 0
mirror of https://github.com/apache/datafusion-sqlparser-rs.git synced 2025-10-14 15:59:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Move TableFactor to be a separate enum

Browse source 
ASTNode can now be renamed SQLExpression, as it represents a node in
the "expression" part of the AST -- other nodes have their own types.
This commit is contained in:
Nickolay Ponomarev 2019-02-06 06:02:54 +03:00
parent e0ceacd1ad
commit 9967031cba
4 changed files with 82 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

72
tests/sqlparser_generic.rs
View file

@ -432,6 +432,14 @@ fn parse_delimited_identifiers() {
// check that quoted identifiers in any position remain quoted after serialization
let sql = r#"SELECT "alias"."bar baz", "myfun"(), "simple id" FROM "a table" AS "alias""#;
let select = verified_only_select(sql);
// check FROM
match select.relation.unwrap() {
TableFactor::Table { name, alias } => {
assert_eq!(vec![r#""a table""#.to_string()], name.0);
assert_eq!(r#""alias""#, alias.unwrap());
}
_ => panic!("Expecting TableFactor::Table"),
}
// check SELECT
assert_eq!(3, select.projection.len());
assert_eq!(
@ -515,45 +523,33 @@ fn parse_case_expression() {
#[test]
fn parse_implicit_join() {
let sql = "SELECT * FROM t1, t2";
match verified_stmt(sql) {
SQLStatement::SQLSelect(SQLSelect { joins, .. }) => {
assert_eq!(joins.len(), 1);
assert_eq!(
joins[0],
Join {
relation: ASTNode::TableFactor {
relation: Box::new(ASTNode::SQLCompoundIdentifier(vec!["t2".to_string()])),
alias: None,
},
join_operator: JoinOperator::Implicit
}
)
}
_ => assert!(false),
}
let select = verified_only_select(sql);
assert_eq!(
&Join {
relation: TableFactor::Table {
name: SQLObjectName(vec!["t2".to_string()]),
alias: None,
},
join_operator: JoinOperator::Implicit
},
only(&select.joins),
);
}
#[test]
fn parse_cross_join() {
let sql = "SELECT * FROM t1 CROSS JOIN t2";
match verified_stmt(sql) {
SQLStatement::SQLSelect(SQLSelect { joins, .. }) => {
assert_eq!(joins.len(), 1);
assert_eq!(
joins[0],
Join {
relation: ASTNode::TableFactor {
relation: Box::new(ASTNode::SQLCompoundIdentifier(vec!["t2".to_string()])),
alias: None,
},
join_operator: JoinOperator::Cross
}
)
}
_ => assert!(false),
}
let select = verified_only_select(sql);
assert_eq!(
&Join {
relation: TableFactor::Table {
name: SQLObjectName(vec!["t2".to_string()]),
alias: None,
},
join_operator: JoinOperator::Cross
},
only(&select.joins),
);
}
#[test]
@ -564,8 +560,8 @@ fn parse_joins_on() {
f: impl Fn(JoinConstraint) -> JoinOperator,
) -> Join {
Join {
relation: ASTNode::TableFactor {
relation: Box::new(ASTNode::SQLCompoundIdentifier(vec![relation.into()])),
relation: TableFactor::Table {
name: SQLObjectName(vec![relation.into()]),
alias,
},
join_operator: f(JoinConstraint::On(ASTNode::SQLBinaryExpr {
@ -615,8 +611,8 @@ fn parse_joins_using() {
f: impl Fn(JoinConstraint) -> JoinOperator,
) -> Join {
Join {
relation: ASTNode::TableFactor {
relation: Box::new(ASTNode::SQLCompoundIdentifier(vec![relation.into()])),
relation: TableFactor::Table {
name: SQLObjectName(vec![relation.into()]),
alias,
},
join_operator: f(JoinConstraint::Using(vec!["c1".into()])),