mirrors/datafusion-sqlparse
1
0
Fork 0
mirror of https://github.com/apache/datafusion-sqlparser-rs.git synced 2025-10-08 13:10:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fix typo in Dialect::supports_eq_alias_assigment (#1478)

Browse source
This commit is contained in:
Andrew Lamb 2024-11-06 10:47:01 -05:00 • committed by GitHub
parent e2197eeca9
commit a9a9d58c38
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/dialect/mod.rs
View file

@ -582,7 +582,7 @@ pub trait Dialect: Debug + Any {
/// SELECT col_alias = col FROM tbl; /// SELECT col_alias = col FROM tbl;
/// SELECT col_alias AS col FROM tbl; /// SELECT col_alias AS col FROM tbl;
/// ``` /// ```
fn supports_eq_alias_assigment(&self) -> bool { fn supports_eq_alias_assignment(&self) -> bool {
false false
} }

2
src/dialect/mssql.rs
View file

@ -50,7 +50,7 @@ impl Dialect for MsSqlDialect {
true true
} }
fn supports_eq_alias_assigment(&self) -> bool { fn supports_eq_alias_assignment(&self) -> bool {
true true
} }

2
src/parser/mod.rs
View file

@ -11235,7 +11235,7 @@ impl<'a> Parser<'a> {
left, left,
op: BinaryOperator::Eq, op: BinaryOperator::Eq,
right, right,
} if self.dialect.supports_eq_alias_assigment() } if self.dialect.supports_eq_alias_assignment()
&& matches!(left.as_ref(), Expr::Identifier(_)) => && matches!(left.as_ref(), Expr::Identifier(_)) =>
{ {
let Expr::Identifier(alias) = *left else { let Expr::Identifier(alias) = *left else {

4
tests/sqlparser_common.rs
View file

@ -11353,7 +11353,7 @@ fn test_any_some_all_comparison() {
#[test] #[test]
fn test_alias_equal_expr() { fn test_alias_equal_expr() {
let dialects = all_dialects_where(|d| d.supports_eq_alias_assigment()); let dialects = all_dialects_where(|d| d.supports_eq_alias_assignment());
let sql = r#"SELECT some_alias = some_column FROM some_table"#; let sql = r#"SELECT some_alias = some_column FROM some_table"#;
let expected = r#"SELECT some_column AS some_alias FROM some_table"#; let expected = r#"SELECT some_column AS some_alias FROM some_table"#;
let _ = dialects.one_statement_parses_to(sql, expected); let _ = dialects.one_statement_parses_to(sql, expected);
@ -11362,7 +11362,7 @@ fn test_alias_equal_expr() {
let expected = r#"SELECT (a * b) AS some_alias FROM some_table"#; let expected = r#"SELECT (a * b) AS some_alias FROM some_table"#;
let _ = dialects.one_statement_parses_to(sql, expected); let _ = dialects.one_statement_parses_to(sql, expected);
let dialects = all_dialects_where(|d| !d.supports_eq_alias_assigment()); let dialects = all_dialects_where(|d| !d.supports_eq_alias_assignment());
let sql = r#"SELECT x = (a * b) FROM some_table"#; let sql = r#"SELECT x = (a * b) FROM some_table"#;
let expected = r#"SELECT x = (a * b) FROM some_table"#; let expected = r#"SELECT x = (a * b) FROM some_table"#;
let _ = dialects.one_statement_parses_to(sql, expected); let _ = dialects.one_statement_parses_to(sql, expected);