mirrors/datafusion-sqlparse
1
0
Fork 0
mirror of https://github.com/apache/datafusion-sqlparser-rs.git synced 2025-10-15 00:09:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix INTERVAL parsing to support expressions and units via dialect (#1398)

Browse source
This commit is contained in:
Samuel Colvin 2024-09-06 15:16:09 +01:00 • committed by GitHub
parent 1bed87a8ea
commit aa714e3447
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 331 additions and 134 deletions
Download patch file Download diff file Expand all files Collapse all files

21
src/dialect/mod.rs
View file

@ -515,6 +515,27 @@ pub trait Dialect: Debug + Any {
fn supports_create_index_with_clause(&self) -> bool {
false
}
/// Whether `INTERVAL` expressions require units (called "qualifiers" in the ANSI SQL spec) to be specified,
/// e.g. `INTERVAL 1 DAY` vs `INTERVAL 1`.
///
/// Expressions within intervals (e.g. `INTERVAL '1' + '1' DAY`) are only allowed when units are required.
///
/// See <https://github.com/sqlparser-rs/sqlparser-rs/pull/1398> for more information.
///
/// When `true`:
/// * `INTERVAL '1' DAY` is VALID
/// * `INTERVAL 1 + 1 DAY` is VALID
/// * `INTERVAL '1' + '1' DAY` is VALID
/// * `INTERVAL '1'` is INVALID
///
/// When `false`:
/// * `INTERVAL '1'` is VALID
/// * `INTERVAL '1' DAY` is VALID — unit is not required, but still allowed
/// * `INTERVAL 1 + 1 DAY` is INVALID
fn require_interval_qualifier(&self) -> bool {
false
}
}
/// This represents the operators for which precedence must be defined