Add support for ASC and DESC in CREATE TABLE column constraints for SQLite. (#1462)

This commit is contained in:
David Caldwell 2024-10-08 09:26:32 -07:00 committed by GitHub
parent 8badcdc200
commit ac956dc963
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 63 additions and 0 deletions

View file

@ -103,4 +103,8 @@ impl Dialect for GenericDialect {
fn supports_limit_comma(&self) -> bool {
true
}
fn supports_asc_desc_in_column_definition(&self) -> bool {
true
}
}

View file

@ -557,6 +557,10 @@ pub trait Dialect: Debug + Any {
fn supports_explain_with_utility_options(&self) -> bool {
false
}
fn supports_asc_desc_in_column_definition(&self) -> bool {
false
}
}
/// This represents the operators for which precedence must be defined

View file

@ -77,4 +77,8 @@ impl Dialect for SQLiteDialect {
fn supports_limit_comma(&self) -> bool {
true
}
fn supports_asc_desc_in_column_definition(&self) -> bool {
true
}
}

View file

@ -6192,6 +6192,20 @@ impl<'a> Parser<'a> {
Ok(Some(ColumnOption::DialectSpecific(vec![
Token::make_keyword("AUTOINCREMENT"),
])))
} else if self.parse_keyword(Keyword::ASC)
&& self.dialect.supports_asc_desc_in_column_definition()
{
// Support ASC for SQLite
Ok(Some(ColumnOption::DialectSpecific(vec![
Token::make_keyword("ASC"),
])))
} else if self.parse_keyword(Keyword::DESC)
&& self.dialect.supports_asc_desc_in_column_definition()
{
// Support DESC for SQLite
Ok(Some(ColumnOption::DialectSpecific(vec![
Token::make_keyword("DESC"),
])))
} else if self.parse_keywords(&[Keyword::ON, Keyword::UPDATE])
&& dialect_of!(self is MySqlDialect | GenericDialect)
{