From b27abf00e2e67b28b25afc9da7c2ddd2a104c449 Mon Sep 17 00:00:00 2001
From: hulk <hulk.website@gmail.com>
Date: Tue, 23 Jul 2024 03:50:24 +0800
Subject: [PATCH] Allow to use `()` as the GROUP BY nothing (#1347)

---
 src/parser/mod.rs         |  5 +++++
 tests/sqlparser_common.rs | 28 ++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+)

diff --git a/src/parser/mod.rs b/src/parser/mod.rs
index 878cabfc..11fa9e4a 100644
--- a/src/parser/mod.rs
+++ b/src/parser/mod.rs
@@ -1487,6 +1487,11 @@ impl<'a> Parser<'a> {
                 let result = self.parse_comma_separated(|p| p.parse_tuple(true, true))?;
                 self.expect_token(&Token::RParen)?;
                 Ok(Expr::Rollup(result))
+            } else if self.consume_tokens(&[Token::LParen, Token::RParen]) {
+                // PostgreSQL allow to use empty tuple as a group by expression,
+                // e.g. `GROUP BY (), name`. Please refer to GROUP BY Clause section in
+                // [PostgreSQL](https://www.postgresql.org/docs/16/sql-select.html)
+                Ok(Expr::Tuple(vec![]))
             } else {
                 self.parse_expr()
             }
diff --git a/tests/sqlparser_common.rs b/tests/sqlparser_common.rs
index ac5098f5..dd3ed051 100644
--- a/tests/sqlparser_common.rs
+++ b/tests/sqlparser_common.rs
@@ -42,6 +42,7 @@ mod test_utils;
 
 #[cfg(test)]
 use pretty_assertions::assert_eq;
+use sqlparser::ast::Expr::Identifier;
 use sqlparser::test_utils::all_dialects_except;
 
 #[test]
@@ -10278,3 +10279,30 @@ fn parse_auto_increment_too_large() {
 
     assert!(res.is_err(), "{res:?}");
 }
+
+#[test]
+fn test_group_by_nothing() {
+    let Select { group_by, .. } = all_dialects_where(|d| d.supports_group_by_expr())
+        .verified_only_select("SELECT count(1) FROM t GROUP BY ()");
+    {
+        std::assert_eq!(
+            GroupByExpr::Expressions(vec![Expr::Tuple(vec![])], vec![]),
+            group_by
+        );
+    }
+
+    let Select { group_by, .. } = all_dialects_where(|d| d.supports_group_by_expr())
+        .verified_only_select("SELECT name, count(1) FROM t GROUP BY name, ()");
+    {
+        std::assert_eq!(
+            GroupByExpr::Expressions(
+                vec![
+                    Identifier(Ident::new("name".to_string())),
+                    Expr::Tuple(vec![])
+                ],
+                vec![]
+            ),
+            group_by
+        );
+    }
+}