Support optional semicolon between statements (#1937)
Some checks are pending
license / Release Audit Tool (RAT) (push) Waiting to run
Rust / codestyle (push) Waiting to run
Rust / lint (push) Waiting to run
Rust / benchmark-lint (push) Waiting to run
Rust / compile (push) Waiting to run
Rust / docs (push) Waiting to run
Rust / compile-no-std (push) Waiting to run
Rust / test (beta) (push) Waiting to run
Rust / test (nightly) (push) Waiting to run
Rust / test (stable) (push) Waiting to run

This commit is contained in:
Yoav Cohen 2025-07-11 14:46:48 +02:00 committed by GitHub
parent ee31b64f9e
commit bc2c4e263d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 59 additions and 3 deletions

View file

@ -222,6 +222,9 @@ pub struct ParserOptions {
/// Controls how literal values are unescaped. See
/// [`Tokenizer::with_unescape`] for more details.
pub unescape: bool,
/// Controls if the parser expects a semi-colon token
/// between statements. Default is `true`.
pub require_semicolon_stmt_delimiter: bool,
}
impl Default for ParserOptions {
@ -229,6 +232,7 @@ impl Default for ParserOptions {
Self {
trailing_commas: false,
unescape: true,
require_semicolon_stmt_delimiter: true,
}
}
}
@ -467,6 +471,10 @@ impl<'a> Parser<'a> {
expecting_statement_delimiter = false;
}
if !self.options.require_semicolon_stmt_delimiter {
expecting_statement_delimiter = false;
}
match self.peek_token().token {
Token::EOF => break,

View file

@ -294,6 +294,11 @@ pub fn all_dialects() -> TestedDialects {
])
}
// Returns all available dialects with the specified parser options
pub fn all_dialects_with_options(options: ParserOptions) -> TestedDialects {
TestedDialects::new_with_options(all_dialects().dialects, options)
}
/// Returns all dialects matching the given predicate.
pub fn all_dialects_where<F>(predicate: F) -> TestedDialects
where

View file

@ -40,8 +40,9 @@ use sqlparser::parser::{Parser, ParserError, ParserOptions};
use sqlparser::tokenizer::Tokenizer;
use sqlparser::tokenizer::{Location, Span};
use test_utils::{
all_dialects, all_dialects_where, alter_table_op, assert_eq_vec, call, expr_from_projection,
join, number, only, table, table_alias, table_from_name, TestedDialects,
all_dialects, all_dialects_where, all_dialects_with_options, alter_table_op, assert_eq_vec,
call, expr_from_projection, join, number, only, table, table_alias, table_from_name,
TestedDialects,
};
#[macro_use]
@ -16115,3 +16116,20 @@ fn test_select_exclude() {
ParserError::ParserError("Expected: end of statement, found: EXCLUDE".to_string())
);
}
#[test]
fn test_no_semicolon_required_between_statements() {
let sql = r#"
SELECT * FROM tbl1
SELECT * FROM tbl2
"#;
let dialects = all_dialects_with_options(ParserOptions {
trailing_commas: false,
unescape: true,
require_semicolon_stmt_delimiter: false,
});
let stmts = dialects.parse_sql_statements(sql).unwrap();
assert_eq!(stmts.len(), 2);
assert!(stmts.iter().all(|s| matches!(s, Statement::Query { .. })));
}

View file

@ -32,7 +32,7 @@ use sqlparser::ast::DeclareAssignment::MsSqlAssignment;
use sqlparser::ast::Value::SingleQuotedString;
use sqlparser::ast::*;
use sqlparser::dialect::{GenericDialect, MsSqlDialect};
use sqlparser::parser::{Parser, ParserError};
use sqlparser::parser::{Parser, ParserError, ParserOptions};
#[test]
fn parse_mssql_identifiers() {
@ -2327,6 +2327,18 @@ fn ms() -> TestedDialects {
TestedDialects::new(vec![Box::new(MsSqlDialect {})])
}
// MS SQL dialect with support for optional semi-colon statement delimiters
fn tsql() -> TestedDialects {
TestedDialects::new_with_options(
vec![Box::new(MsSqlDialect {})],
ParserOptions {
trailing_commas: false,
unescape: true,
require_semicolon_stmt_delimiter: false,
},
)
}
fn ms_and_generic() -> TestedDialects {
TestedDialects::new(vec![Box::new(MsSqlDialect {}), Box::new(GenericDialect {})])
}
@ -2483,3 +2495,15 @@ fn parse_mssql_grant() {
fn parse_mssql_deny() {
ms().verified_stmt("DENY SELECT ON my_table TO public, db_admin");
}
#[test]
fn test_tsql_no_semicolon_delimiter() {
let sql = r#"
DECLARE @X AS NVARCHAR(MAX)='x'
DECLARE @Y AS NVARCHAR(MAX)='y'
"#;
let stmts = tsql().parse_sql_statements(sql).unwrap();
assert_eq!(stmts.len(), 2);
assert!(stmts.iter().all(|s| matches!(s, Statement::Declare { .. })));
}

View file

@ -1442,6 +1442,7 @@ fn parse_escaped_quote_identifiers_with_no_escape() {
ParserOptions {
trailing_commas: false,
unescape: false,
require_semicolon_stmt_delimiter: true,
}
)
.verified_stmt(sql),