mirrors/datafusion-sqlparse
1
0
Fork 0
mirror of https://github.com/apache/datafusion-sqlparser-rs.git synced 2025-10-10 22:12:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Add a note discouraging new use of dialect_of macro (#1448)

Browse source
This commit is contained in:
Andrew Lamb 2024-09-30 07:08:13 -04:00 • committed by GitHub
parent 51cbd5a3e6
commit ce2686a169
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/dialect/mod.rs
View file

@ -60,6 +60,13 @@ use alloc::boxed::Box;
/// Convenience check if a [`Parser`] uses a certain dialect. /// Convenience check if a [`Parser`] uses a certain dialect.
/// ///
/// Note: when possible please the new style, adding a method to the [`Dialect`]
/// trait rather than using this macro.
///
/// The benefits of adding a method on `Dialect` over this macro are:
/// 1. user defined [`Dialect`]s can customize the parsing behavior
/// 2. The differences between dialects can be clearly documented in the trait
///
/// `dialect_of!(parser Is SQLiteDialect | GenericDialect)` evaluates /// `dialect_of!(parser Is SQLiteDialect | GenericDialect)` evaluates
/// to `true` if `parser.dialect` is one of the [`Dialect`]s specified. /// to `true` if `parser.dialect` is one of the [`Dialect`]s specified.
macro_rules! dialect_of { macro_rules! dialect_of {