mirror of
https://github.com/apache/datafusion-sqlparser-rs.git
synced 2025-07-07 17:04:59 +00:00
chore: fix some comments (#1184)
Signed-off-by: sunxunle <sunxunle@gmail.com>
This commit is contained in:
parent
2bf93a470c
commit
e976a2ee43
4 changed files with 5 additions and 5 deletions
|
@ -151,7 +151,7 @@ maintain this crate is limited. Please read the following sections carefully.
|
|||
### New Syntax
|
||||
|
||||
The most commonly accepted PRs add support for or fix a bug in a feature in the
|
||||
SQL standard, or a a popular RDBMS, such as Microsoft SQL
|
||||
SQL standard, or a popular RDBMS, such as Microsoft SQL
|
||||
Server or PostgreSQL, will likely be accepted after a brief
|
||||
review. Any SQL feature that is dialect specific should be parsed by *both* the relevant [`Dialect`]
|
||||
as well as [`GenericDialect`].
|
||||
|
|
|
@ -4649,7 +4649,7 @@ pub struct Function {
|
|||
pub args: Vec<FunctionArg>,
|
||||
/// e.g. `x > 5` in `COUNT(x) FILTER (WHERE x > 5)`
|
||||
pub filter: Option<Box<Expr>>,
|
||||
// Snowflake/MSSQL supports diffrent options for null treatment in rank functions
|
||||
// Snowflake/MSSQL supports different options for null treatment in rank functions
|
||||
pub null_treatment: Option<NullTreatment>,
|
||||
pub over: Option<WindowType>,
|
||||
// aggregate functions may specify eg `COUNT(DISTINCT x)`
|
||||
|
|
|
@ -93,7 +93,7 @@ macro_rules! dialect_of {
|
|||
pub trait Dialect: Debug + Any {
|
||||
/// Determine the [`TypeId`] of this dialect.
|
||||
///
|
||||
/// By default, return the same [`TypeId`] as [`Any::type_id`]. Can be overriden
|
||||
/// By default, return the same [`TypeId`] as [`Any::type_id`]. Can be overridden
|
||||
/// by dialects that behave like other dialects
|
||||
/// (for example when wrapping a dialect).
|
||||
fn dialect(&self) -> TypeId {
|
||||
|
|
|
@ -55,7 +55,7 @@ fn pragma_eq_style() {
|
|||
}
|
||||
}
|
||||
#[test]
|
||||
fn pragma_funciton_style() {
|
||||
fn pragma_function_style() {
|
||||
let sql = "PRAGMA cache_size(10)";
|
||||
match sqlite_and_generic().verified_stmt(sql) {
|
||||
Statement::Pragma {
|
||||
|
@ -103,7 +103,7 @@ fn pragma_function_string_style() {
|
|||
}
|
||||
|
||||
#[test]
|
||||
fn pragma_eq_placehoder_style() {
|
||||
fn pragma_eq_placeholder_style() {
|
||||
let sql = "PRAGMA table_info = ?";
|
||||
match sqlite_and_generic().verified_stmt(sql) {
|
||||
Statement::Pragma {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue