mirrors/datafusion-sqlparse
1
0
Fork 0
mirror of https://github.com/apache/datafusion-sqlparser-rs.git synced 2025-07-08 01:15:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

chore: fix some comments (#1184)

Browse source 
Signed-off-by: sunxunle <sunxunle@gmail.com>
This commit is contained in:
sunxunle 2024-04-07 01:06:53 +08:00 • committed by GitHub
parent 2bf93a470c
commit e976a2ee43
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
README.md
View file

@ -151,7 +151,7 @@ maintain this crate is limited. Please read the following sections carefully.
### New Syntax ### New Syntax
The most commonly accepted PRs add support for or fix a bug in a feature in the The most commonly accepted PRs add support for or fix a bug in a feature in the
SQL standard, or a a popular RDBMS, such as Microsoft SQL SQL standard, or a popular RDBMS, such as Microsoft SQL
Server or PostgreSQL, will likely be accepted after a brief Server or PostgreSQL, will likely be accepted after a brief
review. Any SQL feature that is dialect specific should be parsed by *both* the relevant [`Dialect`] review. Any SQL feature that is dialect specific should be parsed by *both* the relevant [`Dialect`]
as well as [`GenericDialect`]. as well as [`GenericDialect`].

2
src/ast/mod.rs
View file

@ -4649,7 +4649,7 @@ pub struct Function {
pub args: Vec<FunctionArg>, pub args: Vec<FunctionArg>,
/// e.g. `x > 5` in `COUNT(x) FILTER (WHERE x > 5)` /// e.g. `x > 5` in `COUNT(x) FILTER (WHERE x > 5)`
pub filter: Option<Box<Expr>>, pub filter: Option<Box<Expr>>,
// Snowflake/MSSQL supports diffrent options for null treatment in rank functions // Snowflake/MSSQL supports different options for null treatment in rank functions
pub null_treatment: Option<NullTreatment>, pub null_treatment: Option<NullTreatment>,
pub over: Option<WindowType>, pub over: Option<WindowType>,
// aggregate functions may specify eg `COUNT(DISTINCT x)` // aggregate functions may specify eg `COUNT(DISTINCT x)`

2
src/dialect/mod.rs
View file

@ -93,7 +93,7 @@ macro_rules! dialect_of {
pub trait Dialect: Debug + Any { pub trait Dialect: Debug + Any {
/// Determine the [`TypeId`] of this dialect. /// Determine the [`TypeId`] of this dialect.
/// ///
/// By default, return the same [`TypeId`] as [`Any::type_id`]. Can be overriden /// By default, return the same [`TypeId`] as [`Any::type_id`]. Can be overridden
/// by dialects that behave like other dialects /// by dialects that behave like other dialects
/// (for example when wrapping a dialect). /// (for example when wrapping a dialect).
fn dialect(&self) -> TypeId { fn dialect(&self) -> TypeId {

4
tests/sqlparser_sqlite.rs
View file

@ -55,7 +55,7 @@ fn pragma_eq_style() {
} }
} }
#[test] #[test]
fn pragma_funciton_style() { fn pragma_function_style() {
let sql = "PRAGMA cache_size(10)"; let sql = "PRAGMA cache_size(10)";
match sqlite_and_generic().verified_stmt(sql) { match sqlite_and_generic().verified_stmt(sql) {
Statement::Pragma { Statement::Pragma {
@ -103,7 +103,7 @@ fn pragma_function_string_style() {
} }
#[test] #[test]
fn pragma_eq_placehoder_style() { fn pragma_eq_placeholder_style() {
let sql = "PRAGMA table_info = ?"; let sql = "PRAGMA table_info = ?";
match sqlite_and_generic().verified_stmt(sql) { match sqlite_and_generic().verified_stmt(sql) {
Statement::Pragma { Statement::Pragma {