Support optional table for ANALYZE statement (#1599)

This commit is contained in:
yuyang 2024-12-19 17:18:45 +08:00 committed by GitHub
parent 6523dabcf8
commit eae5629fb8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 16 additions and 2 deletions

View file

@ -2354,6 +2354,7 @@ pub enum Statement {
cache_metadata: bool,
noscan: bool,
compute_statistics: bool,
has_table_keyword: bool,
},
/// ```sql
/// TRUNCATE
@ -3651,8 +3652,13 @@ impl fmt::Display for Statement {
cache_metadata,
noscan,
compute_statistics,
has_table_keyword,
} => {
write!(f, "ANALYZE TABLE {table_name}")?;
write!(
f,
"ANALYZE{}{table_name}",
if *has_table_keyword { " TABLE " } else { " " }
)?;
if let Some(ref parts) = partitions {
if !parts.is_empty() {
write!(f, " PARTITION ({})", display_comma_separated(parts))?;

View file

@ -284,6 +284,7 @@ impl Spanned for Statement {
cache_metadata: _,
noscan: _,
compute_statistics: _,
has_table_keyword: _,
} => union_spans(
core::iter::once(table_name.span())
.chain(partitions.iter().flat_map(|i| i.iter().map(|k| k.span())))

View file

@ -851,7 +851,7 @@ impl<'a> Parser<'a> {
}
pub fn parse_analyze(&mut self) -> Result<Statement, ParserError> {
self.expect_keyword(Keyword::TABLE)?;
let has_table_keyword = self.parse_keyword(Keyword::TABLE);
let table_name = self.parse_object_name(false)?;
let mut for_columns = false;
let mut cache_metadata = false;
@ -896,6 +896,7 @@ impl<'a> Parser<'a> {
}
Ok(Statement::Analyze {
has_table_keyword,
table_name,
for_columns,
columns,

View file

@ -562,6 +562,12 @@ fn parse_select_with_table_alias() {
);
}
#[test]
fn parse_analyze() {
verified_stmt("ANALYZE TABLE test_table");
verified_stmt("ANALYZE test_table");
}
#[test]
fn parse_invalid_table_name() {
let ast = all_dialects().run_parser_method("db.public..customer", |parser| {