support column type definitions in table aliases (#1526)

This commit is contained in:
Ophir LOJKINE 2024-11-18 15:02:22 +01:00 committed by GitHub
parent 4c629e8520
commit f961efc0c9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 105 additions and 14 deletions

View file

@ -553,7 +553,11 @@ fn parse_select_with_table_alias() {
name: ObjectName(vec![Ident::new("lineitem")]),
alias: Some(TableAlias {
name: Ident::new("l"),
columns: vec![Ident::new("A"), Ident::new("B"), Ident::new("C"),],
columns: vec![
TableAliasColumnDef::from_name("A"),
TableAliasColumnDef::from_name("B"),
TableAliasColumnDef::from_name("C"),
],
}),
args: None,
with_hints: vec![],
@ -5597,6 +5601,40 @@ fn parse_table_function() {
);
}
#[test]
fn parse_select_with_alias_and_column_defs() {
let sql = r#"SELECT * FROM jsonb_to_record('{"a": "x", "b": 2}'::JSONB) AS x (a TEXT, b INT)"#;
let select = verified_only_select(sql);
match only(&select.from) {
TableWithJoins {
relation: TableFactor::Table {
alias: Some(alias), ..
},
..
} => {
assert_eq!(alias.name.value, "x");
assert_eq!(
alias.columns,
vec![
TableAliasColumnDef {
name: Ident::new("a"),
data_type: Some(DataType::Text),
},
TableAliasColumnDef {
name: Ident::new("b"),
data_type: Some(DataType::Int(None)),
},
]
);
}
_ => unreachable!(
"Expecting only TableWithJoins with TableFactor::Table, got {:#?}",
select.from
),
}
}
#[test]
fn parse_unnest() {
let sql = "SELECT UNNEST(make_array(1, 2, 3))";
@ -6372,7 +6410,10 @@ fn parse_cte_renamed_columns() {
let sql = "WITH cte (col1, col2) AS (SELECT foo, bar FROM baz) SELECT * FROM cte";
let query = all_dialects().verified_query(sql);
assert_eq!(
vec![Ident::new("col1"), Ident::new("col2")],
vec![
TableAliasColumnDef::from_name("col1"),
TableAliasColumnDef::from_name("col2")
],
query
.with
.unwrap()
@ -6401,10 +6442,7 @@ fn parse_recursive_cte() {
value: "nums".to_string(),
quote_style: None,
},
columns: vec![Ident {
value: "val".to_string(),
quote_style: None,
}],
columns: vec![TableAliasColumnDef::from_name("val")],
},
query: Box::new(cte_query),
from: None,
@ -9347,7 +9385,10 @@ fn parse_pivot_table() {
value: "p".to_string(),
quote_style: None
},
columns: vec![Ident::new("c"), Ident::new("d")],
columns: vec![
TableAliasColumnDef::from_name("c"),
TableAliasColumnDef::from_name("d"),
],
}),
}
);
@ -9408,8 +9449,8 @@ fn parse_unpivot_table() {
name: Ident::new("u"),
columns: ["product", "quarter", "quantity"]
.into_iter()
.map(Ident::new)
.collect()
.map(TableAliasColumnDef::from_name)
.collect(),
}),
}
);