From 367ff7278883bfc48b117f72bf0c231ecff4e984 Mon Sep 17 00:00:00 2001 From: Pavel Minaev Date: Wed, 29 Jan 2020 13:37:53 -0800 Subject: [PATCH] Send both "ptvsd" and "debugpy" telemetry events for smooth transition. --- src/debugpy/adapter/ide.py | 10 ++++++++++ tests/debug/session.py | 28 +++++++++++++++++++--------- 2 files changed, 29 insertions(+), 9 deletions(-) diff --git a/src/debugpy/adapter/ide.py b/src/debugpy/adapter/ide.py index 09a3aeed..3aefe893 100644 --- a/src/debugpy/adapter/ide.py +++ b/src/debugpy/adapter/ide.py @@ -77,6 +77,16 @@ class IDE(components.Component, sockets.ClientConnection): session.ide = self session.register() + # For the transition period, send the telemetry events with both old and new + # name. The old one should be removed once the new one lights up. + self.channel.send_event( + "output", + { + "category": "telemetry", + "output": "ptvsd", + "data": {"packageVersion": debugpy.__version__}, + }, + ) self.channel.send_event( "output", { diff --git a/tests/debug/session.py b/tests/debug/session.py index 057b3306..92d37f8b 100644 --- a/tests/debug/session.py +++ b/tests/debug/session.py @@ -149,9 +149,7 @@ class Session(object): """ self.log_dir = ( - None - if log.log_dir is None - else py.path.local(log.log_dir) / str(self) + None if log.log_dir is None else py.path.local(log.log_dir) / str(self) ) """The log directory for this session. Passed via DEBUGPY_LOG_DIR to all spawned child processes. @@ -530,12 +528,24 @@ class Session(object): self.channel = messaging.JsonMessageChannel(stream, handlers) self.channel.start() - telemetry = self.wait_for_next_event("output") - assert telemetry == { - "category": "telemetry", - "output": "debugpy", - "data": {"packageVersion": some.str}, - } + self.wait_for_next( + timeline.Event( + "output", + { + "category": "telemetry", + "output": "ptvsd", + "data": {"packageVersion": some.str}, + }, + ) + & timeline.Event( + "output", + { + "category": "telemetry", + "output": "debugpy", + "data": {"packageVersion": some.str}, + }, + ) + ) self.request( "initialize",