Updating telemetry and some comments (#1825)

* Change version field name in telemetry
* Add info on where to set justMyCode
* Address comments.
This commit is contained in:
Karthik Nadig 2019-10-03 20:30:05 -07:00 committed by GitHub
parent 66f37523ed
commit ffc6306d8b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 4 deletions

View file

@ -356,7 +356,8 @@ class NetCommandFactoryJson(NetCommandFactory):
def make_skipped_step_in_because_of_filters(self, py_db, frame):
msg = 'Frame skipped from debugging during step-in.'
if py_db.get_use_libraries_filter():
msg += '\nNote: may have been skipped because of "justMyCode" option (default == true).'
msg += ('\nNote: may have been skipped because of "justMyCode" option (default == true). '
'Try setting \"justMyCode\": false in the debug configuration (e.g., launch.json).')
body = OutputEventBody(msg, category='console')
event = OutputEvent(body)

View file

@ -582,7 +582,8 @@ class PyDevJsonCommandProcessor(object):
elif error_code == self.api.ADD_BREAKPOINT_FILE_EXCLUDED_BY_FILTERS:
error_msg = 'Breakpoint in file excluded by filters.'
if py_db.get_use_libraries_filter():
error_msg += '\nNote: may be excluded because of "justMyCode" option (default == true).'
error_msg += ('\nNote: may be excluded because of "justMyCode" option (default == true).'
'Try setting \"justMyCode\": false in the debug configuration (e.g., launch.json).')
else:
# Shouldn't get here.

View file

@ -56,7 +56,7 @@ class IDE(components.Component):
{
"category": "telemetry",
"output": "ptvsd.adapter",
"data": {"version": ptvsd.__version__},
"data": {"packageVersion": ptvsd.__version__},
},
)

View file

@ -483,7 +483,7 @@ class Session(object):
assert telemetry == {
"category": "telemetry",
"output": "ptvsd.adapter",
"data": {"version": some.str},
"data": {"packageVersion": some.str},
}
self.request(