mirrors/django-components
1
0
Fork 0
mirror of https://github.com/django-components/django-components.git synced 2025-09-27 07:59:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #207 from hjalves/master

Browse source 
Issue loading media when RENDER_DEPENDENCIES True
This commit is contained in:
Emil Stenström 2023-01-07 13:31:42 +01:00 • committed by GitHub
commit 0f601628b5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
django_components/middleware.py
View file

@ -32,7 +32,7 @@ class ComponentDependencyMiddleware:
"RENDER_DEPENDENCIES", False
)
and not isinstance(response, StreamingHttpResponse)
and response["Content-Type"].startswith("text/html")
and response.get("Content-Type", "").startswith("text/html")
):
response.content = process_response_content(response.content)
return response

12
tests/test_dependency_rendering.py
View file

@ -1,7 +1,11 @@
from unittest.mock import Mock
from django.http import HttpResponseNotModified
from django.template import Template
from django.test import override_settings
from django_components import component
from django_components.middleware import ComponentDependencyMiddleware
from .django_test_setup import * # NOQA
from .test_templatetags import SimpleComponent
@ -380,3 +384,11 @@ class ComponentMediaRenderingTests(SimpleTestCase):
)
rendered = create_and_process_template_response(template)
self.assertNotIn("_RENDERED", rendered)
def test_middleware_response_without_content_type(self):
response = HttpResponseNotModified()
middleware = ComponentDependencyMiddleware(
get_response=lambda _: response
)
request = Mock()
self.assertEqual(response, middleware(request=request))