mirrors/django-components
1
0
Fork 0
mirror of https://github.com/django-components/django-components.git synced 2025-09-26 15:39:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Replace generators with for loops and lists

Browse source
This commit is contained in:
Bradley Stuart Kirton 2020-07-09 10:10:52 +02:00 • committed by Emil Stenström
parent 06f7cd9b3a
commit 77e5e03e45
1 changed files with 18 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

30
django_components/templatetags/component_tags.py
View file

@ -39,43 +39,49 @@ register = template.Library()
COMPONENT_CONTEXT_KEY = "component_context" COMPONENT_CONTEXT_KEY = "component_context"
def iter_components_from_registry(registry): def get_components_from_registry(registry):
"""Yields unique components from the registry.""" """Returns a list unique components from the registry."""
unique_component_classes = set(registry.all().values()) unique_component_classes = set(registry.all().values())
components = []
for component_class in unique_component_classes: for component_class in unique_component_classes:
yield component_class() components.append(component_class())
return components
@register.simple_tag(name="component_dependencies") @register.simple_tag(name="component_dependencies")
def component_dependencies_tag(): def component_dependencies_tag():
"""Render both the CSS and JS dependency tags.""" """Render both the CSS and JS dependency tags."""
component_gen = iter_components_from_registry(registry) rendered_dependencies = []
dependency_gen = map(lambda x: x.render_dependencies(), component_gen) for component in get_components_from_registry(registry):
rendered_dependencies.append(component.render_dependencies())
return mark_safe("\n".join(dependency_gen)) return mark_safe("\n".join(rendered_dependencies))
@register.simple_tag(name="component_css_dependencies") @register.simple_tag(name="component_css_dependencies")
def component_css_dependencies_tag(): def component_css_dependencies_tag():
"""Render the CSS tags.""" """Render the CSS tags."""
component_gen = iter_components_from_registry(registry) rendered_dependencies = []
dependency_gen = map(lambda x: x.render_css_dependencies(), component_gen) for component in get_components_from_registry(registry):
rendered_dependencies.append(component.render_css_dependencies())
return mark_safe("\n".join(dependency_gen)) return mark_safe("\n".join(rendered_dependencies))
@register.simple_tag(name="component_js_dependencies") @register.simple_tag(name="component_js_dependencies")
def component_js_dependencies_tag(): def component_js_dependencies_tag():
"""Render the JS tags.""" """Render the JS tags."""
component_gen = iter_components_from_registry(registry) rendered_dependencies = []
dependency_gen = map(lambda x: x.render_js_dependencies(), component_gen) for component in get_components_from_registry(registry):
rendered_dependencies.append(component.render_js_dependencies())
return mark_safe("\n".join(dependency_gen)) return mark_safe("\n".join(rendered_dependencies))
@register.simple_tag(name="component") @register.simple_tag(name="component")