mirrors/django-components
1
0
Fork 0
mirror of https://github.com/django-components/django-components.git synced 2025-08-09 00:37:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: do not render slot tag when extracting fill tags (#786)

Browse source 
* fix: do not render slot tag when extracting fill tags

* refactor: show component path in error message

* docs: update changelog

* refactor: fix tests
This commit is contained in:
Juro Oravec 2024-11-27 17:19:41 +01:00 • committed by GitHub
parent 5a23101038
commit dd6d668b5e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 182 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

26
src/django_components/component.py
View file

@ -617,7 +617,31 @@ class Component(
try:
return self._render_impl(context, args, kwargs, slots, escape_slots_content, type, render_dependencies)
except Exception as err:
raise _type(err)(f"An error occured while rendering component '{self.name}':\n{repr(err)}") from err
# Nicely format the error message to include the component path.
# E.g.
# ```
# KeyError: "An error occured while rendering components ProjectPage > ProjectLayoutTabbed >
# Layout > RenderContextProvider > Base > TabItem:
# Component 'TabItem' tried to inject a variable '_tab' before it was provided.
# ```
if not hasattr(err, "_components"):
err._components = [] # type: ignore[attr-defined]
components = getattr(err, "_components", [])
# Access the exception's message, see https://stackoverflow.com/a/75549200/9788634
if not components:
orig_msg = err.args[0]
else:
orig_msg = err.args[0].split("\n", 1)[1]
components.insert(0, self.name)
comp_path = " > ".join(components)
prefix = f"An error occured while rendering components {comp_path}:\n"
err.args = (prefix + orig_msg,) # tuple of one
raise err
def _render_impl(
self,