mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-04 02:48:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Made reused RequestFactory instances class attributes.

Browse source
This commit is contained in:
Simon Charette 2018-11-26 14:01:27 -05:00 • committed by Tim Graham
parent 7f63b894c0
commit 0f212db29d
25 changed files with 93 additions and 109 deletions
Download patch file Download diff file Expand all files Collapse all files

21
tests/sessions_tests/tests.py
View file

@ -625,10 +625,11 @@ class CacheSessionTests(SessionTestsMixin, unittest.TestCase):
class SessionMiddlewareTests(TestCase):
request_factory = RequestFactory()
@override_settings(SESSION_COOKIE_SECURE=True)
def test_secure_session_cookie(self):
request = RequestFactory().get('/')
request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()
@ -642,7 +643,7 @@ class SessionMiddlewareTests(TestCase):
@override_settings(SESSION_COOKIE_HTTPONLY=True)
def test_httponly_session_cookie(self):
request = RequestFactory().get('/')
request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()
@ -660,7 +661,7 @@ class SessionMiddlewareTests(TestCase):
@override_settings(SESSION_COOKIE_SAMESITE='Strict')
def test_samesite_session_cookie(self):
request = RequestFactory().get('/')
request = self.request_factory.get('/')
response = HttpResponse()
middleware = SessionMiddleware()
middleware.process_request(request)
@ -670,7 +671,7 @@ class SessionMiddlewareTests(TestCase):
@override_settings(SESSION_COOKIE_HTTPONLY=False)
def test_no_httponly_session_cookie(self):
request = RequestFactory().get('/')
request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()
@ -687,7 +688,7 @@ class SessionMiddlewareTests(TestCase):
)
def test_session_save_on_500(self):
request = RequestFactory().get('/')
request = self.request_factory.get('/')
response = HttpResponse('Horrible error')
response.status_code = 500
middleware = SessionMiddleware()
@ -704,7 +705,7 @@ class SessionMiddlewareTests(TestCase):
def test_session_update_error_redirect(self):
path = '/foo/'
request = RequestFactory().get(path)
request = self.request_factory.get(path)
response = HttpResponse()
middleware = SessionMiddleware()
@ -723,7 +724,7 @@ class SessionMiddlewareTests(TestCase):
middleware.process_response(request, response)
def test_session_delete_on_end(self):
request = RequestFactory().get('/')
request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()
@ -750,7 +751,7 @@ class SessionMiddlewareTests(TestCase):
@override_settings(SESSION_COOKIE_DOMAIN='.example.local', SESSION_COOKIE_PATH='/example/')
def test_session_delete_on_end_with_custom_domain_and_path(self):
request = RequestFactory().get('/')
request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()
@ -778,7 +779,7 @@ class SessionMiddlewareTests(TestCase):
)
def test_flush_empty_without_session_cookie_doesnt_set_cookie(self):
request = RequestFactory().get('/')
request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()
@ -799,7 +800,7 @@ class SessionMiddlewareTests(TestCase):
If a session is emptied of data but still has a key, it should still
be updated.
"""
request = RequestFactory().get('/')
request = self.request_factory.get('/')
response = HttpResponse('Session test')
middleware = SessionMiddleware()