mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-04 02:48:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Refs #15667 -- Prevented newlines in attrs.html widget rendering.

Browse source 
Removed the trailing newline from widget attrs.html template.
The solution may be revisited by fixing refs #9198 but not
for Django 1.11.

Thanks Dmitry Ivanchenko for the report and Preston Timmons for advice.
This commit is contained in:
Dmitry 2017-01-07 02:11:32 +02:00 • committed by Tim Graham
parent 7a6863c338
commit 12cefee5d8
3 changed files with 12 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/forms_tests/widget_tests/base.py
View file

@ -17,11 +17,12 @@ class WidgetTest(SimpleTestCase):
cls.renderers = [cls.django_renderer] + ([cls.jinja2_renderer] if cls.jinja2_renderer else [])
super(WidgetTest, cls).setUpClass()
def check_html(self, widget, name, value, html='', attrs=None, **kwargs):
def check_html(self, widget, name, value, html='', attrs=None, strict=False, **kwargs):
assertEqual = self.assertEqual if strict else self.assertHTMLEqual
if self.jinja2_renderer:
output = widget.render(name, value, attrs=attrs, renderer=self.jinja2_renderer, **kwargs)
# Django escapes quotes with '"' while Jinja2 uses '"'.
self.assertHTMLEqual(output.replace('"', '"'), html)
assertEqual(output.replace('"', '"'), html)
output = widget.render(name, value, attrs=attrs, renderer=self.django_renderer, **kwargs)
self.assertHTMLEqual(output, html)
assertEqual(output, html)