mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-07-26 14:44:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Removed cases of six.iter* wrapped in a list()

Browse source 
There's absolutely no advantage [and a mild performance hit] to using six.iter*
in these cases.
This commit is contained in:
Curtis Maloney 2015-04-18 00:25:11 +10:00
parent 36e90d1f45
commit 14ecbd02a3
10 changed files with 14 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

2
django/forms/widgets.py
View file

@ -988,7 +988,7 @@ class SelectDateWidget(Widget):
html = {}
choices = [(i, i) for i in self.years]
html['year'] = self.create_select(name, self.year_field, value, year_val, choices, self.year_none_value)
choices = list(six.iteritems(self.months))
choices = list(self.months.items())
html['month'] = self.create_select(name, self.month_field, value, month_val, choices, self.month_none_value)
choices = [(i, i) for i in range(1, 32)]
html['day'] = self.create_select(name, self.day_field, value, day_val, choices, self.day_none_value)