mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-08-17 01:00:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixed #36165 -- Made PostgreSQL's SchemaEditor._delete_index_sql() respect the "sql" argument.

Browse source 
This is a follow up of bd366ca2ae.

Thank you Daniel Finch for the report.
This commit is contained in:
Natalia 2025-02-05 12:08:44 -03:00 • committed by nessita
parent e2a8f4dac8
commit 1f33f21fca
2 changed files with 25 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

24
tests/postgres_tests/test_indexes.py
View file

@ -665,6 +665,30 @@ class SchemaTests(PostgreSQLTestCase):
str(index.create_sql(CharFieldModel, editor)),
)
def test_custom_sql(self):
class CustomSQLIndex(PostgresIndex):
sql_create_index = "SELECT 1"
sql_delete_index = "SELECT 2"
def create_sql(self, model, schema_editor, using="", **kwargs):
kwargs.setdefault("sql", self.sql_create_index)
return super().create_sql(model, schema_editor, using, **kwargs)
def remove_sql(self, model, schema_editor, **kwargs):
kwargs.setdefault("sql", self.sql_delete_index)
return super().remove_sql(model, schema_editor, **kwargs)
index = CustomSQLIndex(fields=["field"], name="custom_sql_idx")
operations = [
(index.create_sql, CustomSQLIndex.sql_create_index),
(index.remove_sql, CustomSQLIndex.sql_delete_index),
]
for operation, expected in operations:
with self.subTest(operation=operation.__name__):
with connection.schema_editor() as editor:
self.assertEqual(expected, str(operation(CharFieldModel, editor)))
def test_op_class(self):
index_name = "test_op_class"
index = Index(