mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-11-25 21:22:14 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fixed #35229 -- Made URL custom error handler check run once.

Browse source
This commit is contained in:
Adam Johnson 2024-02-19 04:58:37 +00:00 • committed by GitHub
parent 5e80390add
commit 28a3fbe004
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 49 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/check_framework/test_urls.py
View file

@ -2,6 +2,7 @@ from django.conf import settings
from django.core.checks.messages import Error, Warning
from django.core.checks.urls import (
E006,
check_custom_error_handlers,
check_url_config,
check_url_namespaces_unique,
check_url_settings,
@ -243,7 +244,7 @@ class CheckCustomErrorHandlersTests(SimpleTestCase):
ROOT_URLCONF="check_framework.urls.bad_function_based_error_handlers",
)
def test_bad_function_based_handlers(self):
result = check_url_config(None)
result = check_custom_error_handlers(None)
self.assertEqual(len(result), 4)
for code, num_params, error in zip([400, 403, 404, 500], [2, 2, 2, 1], result):
with self.subTest("handler{}".format(code)):
@ -264,7 +265,7 @@ class CheckCustomErrorHandlersTests(SimpleTestCase):
ROOT_URLCONF="check_framework.urls.bad_class_based_error_handlers",
)
def test_bad_class_based_handlers(self):
result = check_url_config(None)
result = check_custom_error_handlers(None)
self.assertEqual(len(result), 4)
for code, num_params, error in zip([400, 403, 404, 500], [2, 2, 2, 1], result):
with self.subTest("handler%s" % code):
@ -287,7 +288,7 @@ class CheckCustomErrorHandlersTests(SimpleTestCase):
ROOT_URLCONF="check_framework.urls.bad_error_handlers_invalid_path"
)
def test_bad_handlers_invalid_path(self):
result = check_url_config(None)
result = check_custom_error_handlers(None)
paths = [
"django.views.bad_handler",
"django.invalid_module.bad_handler",
@ -318,14 +319,14 @@ class CheckCustomErrorHandlersTests(SimpleTestCase):
ROOT_URLCONF="check_framework.urls.good_function_based_error_handlers",
)
def test_good_function_based_handlers(self):
result = check_url_config(None)
result = check_custom_error_handlers(None)
self.assertEqual(result, [])
@override_settings(
ROOT_URLCONF="check_framework.urls.good_class_based_error_handlers",
)
def test_good_class_based_handlers(self):
result = check_url_config(None)
result = check_custom_error_handlers(None)
self.assertEqual(result, [])