mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-09-27 20:49:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixed #6785 -- Made QuerySet.get() fetch a limited number of rows.

Browse source 
Co-authored-by: Tim Graham <timograham@gmail.com>
Co-authored-by: Patryk Zawadzki <patrys@room-303.com>
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
This commit is contained in:
Amir Hadi 2019-04-13 14:33:05 +02:00 • committed by Mariusz Felisiak
parent 7c3732a1b4
commit 330638b89f
2 changed files with 32 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
django/db/models/query.py
View file

@ -28,6 +28,9 @@ from django.utils import timezone
from django.utils.functional import cached_property, partition
from django.utils.version import get_version
# The maximum number of results to fetch in a get() query.
MAX_GET_RESULTS = 21
# The maximum number of items to display in a QuerySet.__repr__
REPR_OUTPUT_SIZE = 20
@ -398,6 +401,10 @@ class QuerySet:
clone = self.filter(*args, **kwargs)
if self.query.can_filter() and not self.query.distinct_fields:
clone = clone.order_by()
limit = None
if not clone.query.select_for_update or connections[clone.db].features.supports_select_for_update_with_limit:
limit = MAX_GET_RESULTS
clone.query.set_limits(high=limit)
num = len(clone)
if num == 1:
return clone._result_cache[0]
@ -407,8 +414,10 @@ class QuerySet:
self.model._meta.object_name
)
raise self.model.MultipleObjectsReturned(
"get() returned more than one %s -- it returned %s!" %
(self.model._meta.object_name, num)
'get() returned more than one %s -- it returned %s!' % (
self.model._meta.object_name,
num if not limit or num < limit else 'more than %s' % (limit - 1),
)
)
def create(self, **kwargs):