mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-11-18 11:00:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Simplify execute_sql_flush() signature to drop 'using'

Browse source 
Now infers database alias from self.connection.
Reduces redundancy and clarifies API usage.
This commit is contained in:
utkarsh.arya@zomato.com 2025-11-15 22:56:40 +00:00
parent 537d422942
commit 350e447cb7
4 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
django/core/management/commands/flush.py
View file

@ -60,7 +60,7 @@ Are you sure you want to do this?
if confirm == 'yes': if confirm == 'yes':
try: try:
connection.ops.execute_sql_flush(database, sql_list) connection.ops.execute_sql_flush(sql_list)
except Exception as exc: except Exception as exc:
raise CommandError( raise CommandError(
"Database %s couldn't be flushed. Possible reasons:\n" "Database %s couldn't be flushed. Possible reasons:\n"

4
django/db/backends/base/operations.py
View file

@ -400,9 +400,9 @@ class BaseDatabaseOperations:
""" """
raise NotImplementedError('subclasses of BaseDatabaseOperations must provide a sql_flush() method') raise NotImplementedError('subclasses of BaseDatabaseOperations must provide a sql_flush() method')
def execute_sql_flush(self, using, sql_list): def execute_sql_flush(self, sql_list):
"""Execute a list of SQL statements to flush the database.""" """Execute a list of SQL statements to flush the database."""
with transaction.atomic(using=using, savepoint=self.connection.features.can_rollback_ddl): with transaction.atomic(using=self.connection.alias, savepoint=self.connection.features.can_rollback_ddl):
with self.connection.cursor() as cursor: with self.connection.cursor() as cursor:
for sql in sql_list: for sql in sql_list:
cursor.execute(sql) cursor.execute(sql)

2
tests/backends/base/test_operations.py
View file

@ -172,7 +172,7 @@ class SqlFlushTests(TransactionTestCase):
reset_sequences=True, reset_sequences=True,
allow_cascade=True, allow_cascade=True,
) )
connection.ops.execute_sql_flush(connection.alias, sql_list) connection.ops.execute_sql_flush(sql_list)
with transaction.atomic(): with transaction.atomic():
self.assertIs(Author.objects.exists(), False) self.assertIs(Author.objects.exists(), False)

2
tests/backends/tests.py
View file

@ -162,7 +162,7 @@ class LongNameTest(TransactionTestCase):
VLM_m2m._meta.db_table, VLM_m2m._meta.db_table,
] ]
sql_list = connection.ops.sql_flush(no_style(), tables, reset_sequences=True) sql_list = connection.ops.sql_flush(no_style(), tables, reset_sequences=True)
connection.ops.execute_sql_flush(connection.alias, sql_list) connection.ops.execute_sql_flush(sql_list)
class SequenceResetTest(TestCase): class SequenceResetTest(TestCase):