mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-11-01 12:25:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fixed #11191 - Admin throws 500 instead of 404 for PK of incorrect type

Browse source 
Thanks to mmachine for report and test, and Chris Beaven for the patch



git-svn-id: http://code.djangoproject.com/svn/django/trunk@12011 bcc190cf-cafb-0310-a4f2-bffc1f526a37
This commit is contained in:
Luke Plant 2009-12-28 14:08:11 +00:00
parent 5957052acb
commit 3952d3129c
2 changed files with 27 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/regressiontests/admin_views/tests.py
View file

@ -63,11 +63,20 @@ class AdminViewBasicTest(TestCase):
def testBasicEditGet(self):
"""
A smoke test to ensureGET on the change_view works.
A smoke test to ensure GET on the change_view works.
"""
response = self.client.get('/test_admin/%s/admin_views/section/1/' % self.urlbit)
self.failUnlessEqual(response.status_code, 200)
def testBasicEditGetStringPK(self):
"""
A smoke test to ensure GET on the change_view works (returns an HTTP
404 error, see #11191) when passing a string as the PK argument for a
model with an integer PK field.
"""
response = self.client.get('/test_admin/%s/admin_views/section/abc/' % self.urlbit)
self.failUnlessEqual(response.status_code, 404)
def testBasicAddPost(self):
"""
A smoke test to ensure POST on add_view works.