mirrors/django
1
0
Fork 0
mirror of https://github.com/django/django.git synced 2025-09-26 12:09:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fixed #25939 -- Removed redundant transaction in QuerySet.update_or_create().

Browse source 
There is no need to wrap the save() call in transaction.atomic() as
it's already done down the call stack in Model.save_base().
This commit is contained in:
Ed Bartosh 2015-12-09 14:18:44 +02:00 • committed by Tim Graham
parent 5146e2cf98
commit 423b3afce4
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
django/db/models/query.py
View file

@ -484,9 +484,7 @@ class QuerySet(object):
return obj, created
for k, v in six.iteritems(defaults):
setattr(obj, k, v)
with transaction.atomic(using=self.db, savepoint=False):
obj.save(using=self.db)
obj.save(using=self.db)
return obj, False
def _create_object_from_params(self, lookup, params):